-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use nuxt island to render storybook stories #1728
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasdiez
added
the
status: blocked
Blocked by an issue / missing feature of a dependency, or by another issue
label
Jan 29, 2023
This looks really promising, good job so far! 👏 |
Closing this for now. Couldn't figure out a good way to let nuxt only render the story, since eveything is build by the storybook vite. Will revisit this problem and probably will implement a new storybook build that directly uses the nuxt pipeline to build the storybook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call
http://localhost:3000/__nuxt_island/Storybook
.Question: is there also a method that one call
useNuxt().render(island component, props)
instead of calling the url endpoint. Problem is namely that we get some js objects from storybook and want to render them, without prior serialization. I've opened nuxt/nuxt#18596 for this. Maybe usenitroApp.localCall
?Maybe related: nuxt/framework#5723 (comment)
Also needs SSR, which is currently blocked #1725
Reference: