This repository has been archived by the owner on Oct 20, 2020. It is now read-only.
Added possibility to style Timebar Cells via JS #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 24, 2019 17:17
willbamford
reviewed
May 27, 2019
| @@ -11,7 +11,7 @@ const TrackKey = ({ track, toggleOpen, clickTrackButton }) => { | |||
| hasButton, | |||
| sideComponent | |||
| } = track | |||
| const isExpandable = isOpen !== undefined | |||
| const isExpandable = (isOpen !== undefined) && tracks && (tracks !== undefined) && tracks.length > 0 | |||
There was a problem hiding this comment.
I'm not sure you can rely on this as tracks can be dynamically loaded i.e. only loaded in when you hit toggleOpen (could be wrong - been a while since I looked at this code)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See subject, added possibility to style Timebar Cells via JS (to mark different time spans).