Update Android Gradle plugin to 4.1 version. #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move all android related code to separate file - AndroidPluginsApplier.kt. Use new AGP apis and simplify internal code. Signed-off-by: Yahor Berdnikau <[email protected]>
Signed-off-by: Yahor Berdnikau <[email protected]>
Signed-off-by: Yahor Berdnikau <[email protected]>
JLLeitschuh
reviewed
Nov 18, 2020
Comment on lines
11
to
12
| val commonMain by getting | ||
| val androidMain by getting |
There was a problem hiding this comment.
Are these still needed at all?
JLLeitschuh
reviewed
Nov 18, 2020
| @@ -0,0 +1,108 @@ | |||
| @file:Suppress("UnstableApiUsage") | |||
There was a problem hiding this comment.
Can you apply this a bit more specifically?
Signed-off-by: Yahor Berdnikau <[email protected]>
Signed-off-by: Yahor Berdnikau <[email protected]>
|
@JLLeitschuh sorry for not addressing your review for a long time. Just did it, please check fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change as I used new api and dropped support for build variants meta tasks. New api does not provide such information.