Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: use spaces instead of hsep in timetable GUI #798

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

WenSimEHRP
Copy link
Contributor

Motivation / Problem

The time bar in the timetable window uses an hsep_wide to seperate the arrival/departure abbreviations and the time. This does not work well with languages that use the ideographic colon, or the fullwidth colon, as the gap is now super wide.

zh_CN (fullwidth colon) zh_TW (fullwidth colon) en (halfwidth colon)
image image image

Description

Remove the hsep and add two {SPACE} after the abbreviation. It seems like that these strings are only used in the timetables window.

zh_TW (fullwidth colon) en (halfwidth colon + 2x {SPACE})
image image

Limitations

  • I didn't change other language's translation.
  • Might break text alignment??

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the [guidelines](https://github.com/OpenTTD/OpenTTD/blob/master/docs/eints.md)
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@JGRennison
Copy link
Owner

Seems OK, I will fix the other languages in a separate commit

@JGRennison JGRennison merged commit e8da86c into JGRennison:jgrpp Jan 2, 2025
10 checks passed
@WenSimEHRP WenSimEHRP deleted the timetable-spacing branch January 4, 2025 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants