Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

게시글 응답에 선택지별 득표 수, 게시글 전체 투표 수 반환 구현 #224

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

gywns0417
Copy link
Contributor

@gywns0417 gywns0417 commented Mar 19, 2024

💡 작업 내용

  • 선택지별 득표 수 반환 구현
  • 게시글 전체 투표 수 반환 구현
  • Postman 테스트

💡 자세한 설명

image
선택지별 득표 수 반환 Postman 테스트 완료

image
게시글 전체 투표 수 반환 Postman 테스트 완료

📗 참고 자료 (선택)

📢 리뷰 요구 사항 (선택)

🚩 후속 작업 (선택)

✅ 셀프 체크리스트

  • PR 제목을 형식에 맞게 작성했나요?
  • 브랜치 전략에 맞는 브랜치에 PR을 올리고 있나요? (master/main이 아닙니다.)
  • 이슈는 close 했나요?
  • Reviewers, Labels, Projects를 등록했나요?
  • 작업 도중 문서 수정이 필요한 경우 잘 수정했나요?
  • 테스트는 잘 통과했나요?
  • 불필요한 코드는 제거했나요?

closes #216

@gywns0417 gywns0417 added ✔︎ pull requests pull requests 코드 체크 요청 ✨ feature 구현, 개선 사항 관련 부분 👨🏻‍💻 backend labels Mar 19, 2024
@gywns0417 gywns0417 added this to the Sprint 6 milestone Mar 19, 2024
@gywns0417 gywns0417 requested review from jschoi-96 and Hanjaemo March 19, 2024 14:53
@gywns0417 gywns0417 self-assigned this Mar 19, 2024
@@ -49,6 +51,9 @@ public class PostResponse {
@Schema(description = "태그 리스트", example = "[\"태그1\", \"태그2\", \"태그3\"]")
private List<PostTagDto> postTags;

@Schema(description = "전체 투표 수", example = "15")
private int totalVoteCount;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

totalVotesCount라고 네이밍 짓는건 어떨까요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다! 수정하겠습니다~

@gywns0417 gywns0417 merged commit 7def3bf into dev Mar 22, 2024
@gywns0417 gywns0417 deleted the feat/216-post-vote-count branch March 22, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature 구현, 개선 사항 관련 부분 ✔︎ pull requests pull requests 코드 체크 요청
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants