Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: UI-Homepage 완성 #9

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Feat: UI-Homepage 완성 #9

merged 2 commits into from
Jul 23, 2024

Conversation

CLOUDoort
Copy link
Contributor

@CLOUDoort CLOUDoort commented Jul 22, 2024

💡 작업 내용

  • ✅ Layout file 재설정
  • ✅ UI-Homepage 완성
  • ✅ 카테고리 추가
  • ✅ react-router-dom 라이브러리 설치 및 라우터 설정

💡 자세한 설명

Layout file 재설정

개인적으로 Layout 파일은 제가 작성한 스타일을 더 좋아하는데, 코드리뷰 때 이부분 이야기를 더 하면 좋겠습니다.

카테고리 추가

카테고리는 상수값으로 저장하고, key값은 영어로 value는 한글 그대로 입력했습니다.

✅ 셀프 체크리스트

  • [✅] PR 제목을 형식에 맞게 작성했나요?
  • [✅ ] 브랜치 전략에 맞는 브랜치에 PR을 올리고 있나요? (master/main이 아닙니다.)
  • [✅ ] Reviewers, Labels, Projects를 등록했나요?
스크린샷 2024-07-22 오후 8 00 09

@CLOUDoort CLOUDoort added the ✨feature 구현, 개선 사항 관련 부분 label Jul 22, 2024
Copy link
Contributor

@aquaman122 aquaman122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

레이아웃 디자인도 새로하셨군요! 확인했습니다 고생하셨어요👍

@CLOUDoort CLOUDoort changed the base branch from main to dev July 23, 2024 12:36
@CLOUDoort CLOUDoort merged commit 2cf59ce into dev Jul 23, 2024
@aquaman122 aquaman122 deleted the feat/UI-Home branch July 24, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨feature 구현, 개선 사항 관련 부분
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants