Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev merge #80

Merged
merged 28 commits into from
Oct 1, 2024
Merged

dev merge #80

merged 28 commits into from
Oct 1, 2024

Conversation

CLOUDoort
Copy link
Contributor

πŸ’‘ μž‘μ—… λ‚΄μš©

  • dev merge

πŸ’‘ μžμ„Έν•œ μ„€λͺ…

(κ°€λŠ₯ν•œ ν•œ μžμ„Ένžˆ μž‘μ„±ν•΄ μ£Όμ‹œλ©΄ 도움이 λ©λ‹ˆλ‹€.)

πŸ“— μ°Έκ³  자료 (선택)

πŸ“’ 리뷰 μš”κ΅¬ 사항 (선택)

🚩 후속 μž‘μ—… (선택)

βœ… μ…€ν”„ 체크리슀트

  • PR 제λͺ©μ„ ν˜•μ‹μ— 맞게 μž‘μ„±ν–ˆλ‚˜μš”?
  • 브랜치 μ „λž΅μ— λ§žλŠ” λΈŒλžœμΉ˜μ— PR을 올리고 μžˆλ‚˜μš”? (master/main이 μ•„λ‹™λ‹ˆλ‹€.)
  • μ΄μŠˆλŠ” close ν–ˆλ‚˜μš”?
  • Reviewers, Labels, Projectsλ₯Ό λ“±λ‘ν–ˆλ‚˜μš”?
  • μž‘μ—… 도쀑 λ¬Έμ„œ μˆ˜μ •μ΄ ν•„μš”ν•œ 경우 잘 μˆ˜μ •ν–ˆλ‚˜μš”?
  • ν…ŒμŠ€νŠΈλŠ” 잘 ν†΅κ³Όν–ˆλ‚˜μš”?
  • λΆˆν•„μš”ν•œ μ½”λ“œλŠ” μ œκ±°ν–ˆλ‚˜μš”?

closes #이슈번호

aquaman122 and others added 28 commits September 30, 2024 22:02
1. 사전경맀와 경맀 μƒμ„ΈνŽ˜μ΄μ§€μ˜ routerλ₯Ό 뢄리
1. 사전경맀와 경맀 μƒμ„ΈνŽ˜μ΄μ§€μ˜ routerλ₯Ό 뢄리
1. Details νŽ˜μ΄μ§€λŠ” AuctionDetails으둜 ꡬ체화
1. Details νŽ˜μ΄μ§€λŠ” AuctionDetails으둜 ꡬ체화
1. κΈ°μ‘΄ Detailsμ—μ„œ μƒμ„ΈνŽ˜μ΄μ§€/사전경맀 λͺ¨λ‘λ₯Ό λ‹΄λ‹Ήν–ˆμ§€λ§Œ 이λ₯Ό 뢄리
2. PreAuction νŽ˜μ΄μ§€μ—μ„œ 사전경맀 κ΄€λ ¨λœ 둜직만 λ‹΄λ‹Ή
1. AuctionItem μΈν„°νŽ˜μ΄μŠ€λ₯Ό 생성
1. 기쑴의 mocking μ„œλ²„κ°€ μ•„λ‹Œ μ‹ κ·œ μƒμ„±ν•œ interfaceμ—μ„œ import
1. 이름이 λ°”λ€Œμ–΄ μ‚¬μš©ν•˜μ§€ μ•ŠλŠ” DetailPage import λ¬Έ μ‚­μ œ
1. api λͺ…μ„Έ λ¬Έμ„œμ— 맞좰 preauction item 에 λŒ€ν•œinterface 생성
1. ProgressBarμ—μ„œ μ‚¬μš©ν•˜μ§€ μ•ŠλŠ” isLoading μ‚­μ œ
2. initialTime의 경우 pre auction에선 μ‚¬μš©ν•˜μ§€ μ•ŠκΈ° λ•Œλ¬Έμ— 숫자 ν˜Ήμ€ κ³΅λž€μ΄ props둜 λ„˜μ–΄κ°€λ„λ‘ μˆ˜μ •
3. preAuction νŽ˜μ΄μ§€μ—μ„œ μˆ˜μ •μ΄ ν•„μš”ν•œ λΆ€λΆ„ μž„μ‹œλ‘œ 주석 처리
Fix. 상세 νŽ˜μ΄μ§€ router μˆ˜μ •
@CLOUDoort CLOUDoort merged commit 2efbc42 into main Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants