-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev merge #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix/notification
1. μ¬μ 경맀μ 경맀 μμΈνμ΄μ§μ routerλ₯Ό λΆλ¦¬
1. μ¬μ 경맀μ 경맀 μμΈνμ΄μ§μ routerλ₯Ό λΆλ¦¬
1. Details νμ΄μ§λ AuctionDetailsμΌλ‘ ꡬ체ν
1. Details νμ΄μ§λ AuctionDetailsμΌλ‘ ꡬ체ν
1. κΈ°μ‘΄ Detailsμμ μμΈνμ΄μ§/μ¬μ 경맀 λͺ¨λλ₯Ό λ΄λΉνμ§λ§ μ΄λ₯Ό λΆλ¦¬ 2. PreAuction νμ΄μ§μμ μ¬μ 경맀 κ΄λ ¨λ λ‘μ§λ§ λ΄λΉ
Feat / EmptyBoundary
1. AuctionItem μΈν°νμ΄μ€λ₯Ό μμ±
1. κΈ°μ‘΄μ mocking μλ²κ° μλ μ κ· μμ±ν interfaceμμ import
1. μ΄λ¦μ΄ λ°λμ΄ μ¬μ©νμ§ μλ DetailPage import λ¬Έ μμ
1. api λͺ μΈ λ¬Έμμ λ§μΆ° preauction item μ λνinterface μμ±
1. ProgressBarμμ μ¬μ©νμ§ μλ isLoading μμ 2. initialTimeμ κ²½μ° pre auctionμμ μ¬μ©νμ§ μκΈ° λλ¬Έμ μ«μ νΉμ 곡λμ΄ propsλ‘ λμ΄κ°λλ‘ μμ 3. preAuction νμ΄μ§μμ μμ μ΄ νμν λΆλΆ μμλ‘ μ£Όμ μ²λ¦¬
Fix. μμΈ νμ΄μ§ router μμ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π‘ μμ λ΄μ©
π‘ μμΈν μ€λͺ
(κ°λ₯ν ν μμΈν μμ±ν΄ μ£Όμλ©΄ λμμ΄ λ©λλ€.)
π μ°Έκ³ μλ£ (μ ν)
π’ 리뷰 μꡬ μ¬ν (μ ν)
π© νμ μμ (μ ν)
β μ ν 체ν¬λ¦¬μ€νΈ
closes #μ΄μλ²νΈ