-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: User 페이지 스타일 변경 #48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다!
src/components/user/UserOrder.tsx
Outdated
<div className="pb-10"> | ||
{/* 참여한 정식 경매 내역 */} | ||
<div> | ||
<h2 className="text-xl font-bold mb-4">참여한 정식 경매 내역</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
텍스트 크기는 text-xl 대신 tailwind.config에 있는 text-heading 으로 통일하면 좋을 것 같습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵!
src/components/user/UserOrder.tsx
Outdated
{/* 참여한 정식 경매 내역 */} | ||
<div> | ||
<h2 className="text-xl font-bold mb-4">참여한 정식 경매 내역</h2> | ||
<div className="flex justify-between space-x-3"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flex를 사용할 때는 space보다 gap 사용하는게 좋다고 합니다!
onClick={() => | ||
navigate('/order/history', { | ||
state: { sortType: 'AuctionHistory' }, | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
경로와 sortType을 인자로 받는 함수를 따로 작성하는 것도 좋아보입니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋은 것 같습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
중복되는 경매 내역 UI는 컴포넌트로 따로 만들면 좋아보입니다!
src/main.tsx
Outdated
// return; | ||
// } | ||
// const { worker } = await import('./mocks/broswer'); | ||
// await worker.start(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 설정은 commit안하는게 좋은 것 같습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
엇 네넵!
💡 작업 내용
💡 자세한 설명
🛠️ 유저 페이지 목록
🚩 후속 작업 (선택)
✅ 셀프 체크리스트