Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: rendering error #141

Merged
merged 9 commits into from
Oct 16, 2024
Merged

Fix: rendering error #141

merged 9 commits into from
Oct 16, 2024

Conversation

CLOUDoort
Copy link
Contributor

๐Ÿ’ก ์ž‘์—… ๋‚ด์šฉ

  • ์นดํ…Œ๊ณ ๋ฆฌ ๋ณ„ ๊ฒฝ๋งค ๋ชฉ๋ก ์กฐํšŒ์‹œ URL์„ ๋Œ€๋ฌธ์ž ๋ฐ ์–ธ๋”์Šค์ฝ”์–ด๋ฅผ ์†Œ๋ฌธ์ž ๋ฐ ํ•˜์ดํ”ˆ์œผ๋กœ ๋ณ€๊ฒฝ
  • tsconfig ์„ค์ •์„ es2021๋กœ ๋ณ€๊ฒฝ
  • ์ข…๋ฃŒ์ž„๋ฐ• ๊ฒฝ๋งค ์ถ”๊ฐ€ํ•˜๋Š” ํ…Œ์ŠคํŠธ ๊ธฐ๋Šฅ ์ถ”๊ฐ€
  • Carousel loop ์ œ๊ฑฐ
  • hook์„ ์กฐ๊ฑด์œผ๋กœ ๋ถ€๋ฅด์ง€ ์•Š๊ธฐ ์œ„ํ•ด ์ผ๋ฐ˜ useQuery ํ›…๊ณผ useSuspenseQuery ํ›…์œผ๋กœ ๊ตฌ๋ถ„ํ•จ์œผ๋กœ์จ ๋ Œ๋”๋ง ์—๋Ÿฌ ํ•ด๊ฒฐ
  • local suspense์—์„œ ์‚ฌ์šฉํ•  local spinner ์ž‘์„ฑ

โœ… ์…€ํ”„ ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • PR ์ œ๋ชฉ์„ ํ˜•์‹์— ๋งž๊ฒŒ ์ž‘์„ฑํ–ˆ๋‚˜์š”?
  • ๋ธŒ๋žœ์น˜ ์ „๋žต์— ๋งž๋Š” ๋ธŒ๋žœ์น˜์— PR์„ ์˜ฌ๋ฆฌ๊ณ  ์žˆ๋‚˜์š”? (master/main์ด ์•„๋‹™๋‹ˆ๋‹ค.)
  • ์ด์Šˆ๋Š” close ํ–ˆ๋‚˜์š”?
  • Reviewers, Labels, Projects๋ฅผ ๋“ฑ๋กํ–ˆ๋‚˜์š”?
  • ์ž‘์—… ๋„์ค‘ ๋ฌธ์„œ ์ˆ˜์ •์ด ํ•„์š”ํ•œ ๊ฒฝ์šฐ ์ž˜ ์ˆ˜์ •ํ–ˆ๋‚˜์š”?
  • ํ…Œ์ŠคํŠธ๋Š” ์ž˜ ํ†ต๊ณผํ–ˆ๋‚˜์š”?
  • ๋ถˆํ•„์š”ํ•œ ์ฝ”๋“œ๋Š” ์ œ๊ฑฐํ–ˆ๋‚˜์š”?

closes #140

@CLOUDoort CLOUDoort added โœจfeature ๊ตฌํ˜„, ๊ฐœ์„  ์‚ฌํ•ญ ๊ด€๋ จ ๋ถ€๋ถ„ ๐Ÿ›bug ๋ฒ„๊ทธ ๋ฐœ๊ฒฌ ๐Ÿ‘ฉ๐Ÿปโ€๐Ÿ’ปfrontend ํ”„๋ก ํŠธ์—”๋“œ ์ž‘์—… labels Oct 15, 2024
@CLOUDoort CLOUDoort requested a review from aquaman122 October 15, 2024 14:25
@CLOUDoort CLOUDoort self-assigned this Oct 15, 2024
Copy link
Contributor

@aquaman122 aquaman122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค ๊ณ ์ƒ๋งŽ์œผ์…จ์–ด์š”!๐Ÿ‘

return await axiosInstance(originalRequest);
} catch (refreshError) {
handleTokenError('๋ฆฌํ”„๋ ˆ์‹œ ํ† ํฐ์ด ๋งŒ๋ฃŒ๋˜์—ˆ์Šต๋‹ˆ๋‹ค. ๋‹ค์‹œ ๋กœ๊ทธ์ธํ•ด์ฃผ์„ธ์š”.');
return Promise.reject(refreshError);
}
} else {
removeToken();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logout ์˜ค๋ฅ˜ ์ˆ˜์ •ํ•œ๊ฑฐ ์ถ”ํ›„์— ๊ธฐ๋Šฅ์˜ค๋ฅ˜์ƒ๊ธฐ๋ฉด ๋ณด๊ฐ•ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค... ๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค๐Ÿ‘

@@ -5,7 +5,7 @@ const CategoryItem = ({ code, name, icon }: { code: string; name: string; icon:
const navigate = useNavigate();

const onClickCategory = () => {
navigate(`/product/list?category=${code}`);
navigate(`/product/list?category=${code.toLocaleLowerCase().replaceAll('_', '-')}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ฆฌํŒฉํ† ๋งํ• ๋•Œ ๋Œ€๋ฌธ์ž, _ ๋“ค์–ด๊ฐ„ ๊ฒƒ๋“ค ์ˆ˜์ •ํ•ด๋†“๊ฒ ์Šต๋‹ˆ๋‹ค!

import { useState } from "react";
import { useNavigate } from "react-router-dom";

const Test = () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๐Ÿ‘

@CLOUDoort CLOUDoort merged commit e593151 into dev Oct 16, 2024
@CLOUDoort CLOUDoort deleted the fix/rendering-error branch October 16, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐Ÿ›bug ๋ฒ„๊ทธ ๋ฐœ๊ฒฌ โœจfeature ๊ตฌํ˜„, ๊ฐœ์„  ์‚ฌํ•ญ ๊ด€๋ จ ๋ถ€๋ถ„ ๐Ÿ‘ฉ๐Ÿปโ€๐Ÿ’ปfrontend ํ”„๋ก ํŠธ์—”๋“œ ์ž‘์—…
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants