Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: register post ๋ฐ patch loading #126

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Feat: register post ๋ฐ patch loading #126

merged 3 commits into from
Oct 7, 2024

Conversation

CLOUDoort
Copy link
Contributor

๐Ÿ’ก ์ž‘์—… ๋‚ด์šฉ

  • ๊ฒฝ๋งค ๋“ฑ๋ก ์‹œ post ๋ฐ patch loading button ๊ตฌํ˜„
  • ๊ฒฝ๋งค ์ข…๋ฃŒ๋˜์—ˆ์Œ์„ ์•Œ๋ฆฌ๋Š” label ์ž‘์„ฑ
  • ๊ฒฝ๋งค ๋“ฑ๋ก ์‹œ ์ด๋ฏธ์ง€ ํฌ๊ธฐ ์กฐ์ •

โœ… ์…€ํ”„ ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • PR ์ œ๋ชฉ์„ ํ˜•์‹์— ๋งž๊ฒŒ ์ž‘์„ฑํ–ˆ๋‚˜์š”?
  • ๋ธŒ๋žœ์น˜ ์ „๋žต์— ๋งž๋Š” ๋ธŒ๋žœ์น˜์— PR์„ ์˜ฌ๋ฆฌ๊ณ  ์žˆ๋‚˜์š”? (master/main์ด ์•„๋‹™๋‹ˆ๋‹ค.)
  • ์ด์Šˆ๋Š” close ํ–ˆ๋‚˜์š”?
  • Reviewers, Labels, Projects๋ฅผ ๋“ฑ๋กํ–ˆ๋‚˜์š”?
  • ์ž‘์—… ๋„์ค‘ ๋ฌธ์„œ ์ˆ˜์ •์ด ํ•„์š”ํ•œ ๊ฒฝ์šฐ ์ž˜ ์ˆ˜์ •ํ–ˆ๋‚˜์š”?
  • ํ…Œ์ŠคํŠธ๋Š” ์ž˜ ํ†ต๊ณผํ–ˆ๋‚˜์š”?
  • ๋ถˆํ•„์š”ํ•œ ์ฝ”๋“œ๋Š” ์ œ๊ฑฐํ–ˆ๋‚˜์š”?

closes #์ด์Šˆ๋ฒˆํ˜ธ

@CLOUDoort CLOUDoort added โœจfeature ๊ตฌํ˜„, ๊ฐœ์„  ์‚ฌํ•ญ ๊ด€๋ จ ๋ถ€๋ถ„ ๐Ÿ‘ฉ๐Ÿปโ€๐Ÿ’ปfrontend ํ”„๋ก ํŠธ์—”๋“œ ์ž‘์—… labels Oct 7, 2024
@CLOUDoort CLOUDoort merged commit 1a53c0e into dev Oct 7, 2024
aquaman122
aquaman122 reviewed Oct 7, 2024
View reviewed changes
Copy link
Contributor

@aquaman122 aquaman122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒ๋งŽ์œผ์…จ์Šต๋‹ˆ๋‹ค๐Ÿ‘

src/components/common/atomic/TimeLabel.tsx
@@ -8,7 +8,7 @@ const TimeLabel = ({ time }: { time: number }) => {
aria-label="์‹œ๊ฐ„"
className={`absolute bottom-0 w-full pt-1 text-center bg-white opacity-80 ${color} border-b-2`}
>
{`${formattedTime}์‹œ๊ฐ„ ๋‚จ์Œ`}
{formattedTime === 0 ? <p className='text-red-600'>๊ฒฝ๋งค ์ข…๋ฃŒ</p> : `${formattedTime}์‹œ๊ฐ„ ๋‚จ์Œ`}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์•„ ์ด๊ฑฐ ๋ณ€๊ฒฝํ•ด์ฃผ์…จ๊ตฐ์š”!!

@CLOUDoort CLOUDoort deleted the feat/register-laoading branch October 7, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aquaman122 aquaman122 aquaman122 left review comments

Assignees
No one assigned
Labels
โœจfeature ๊ตฌํ˜„, ๊ฐœ์„  ์‚ฌํ•ญ ๊ด€๋ จ ๋ถ€๋ถ„ ๐Ÿ‘ฉ๐Ÿปโ€๐Ÿ’ปfrontend ํ”„๋ก ํŠธ์—”๋“œ ์ž‘์—…
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CLOUDoort @aquaman122