-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: ProductItem 시간, style, Type 변경, 프로필 이미지 추가 #123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다.
수정사항만 수정해주세요!
className="object-cover w-full h-[10rem] rounded-t" | ||
src={`${product.cdnPath ? product.cdnPath : jordanBlackImage}`} | ||
className="object-cover w-full h-[15rem] rounded-t" | ||
src={`${product.imageUrl ? product.imageUrl : jordanBlackImage}`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
기본이미지 설정은 이제 필요없을 듯 합니다!
이미지 에러 해결했고, 이미지 한 장은 무조건 있으니까요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵!
className="object-cover w-full h-[10rem] rounded-t" | ||
src={`${product.cdnPath ? product.cdnPath : jordanBlackImage}`} | ||
className="object-cover w-full h-[15rem] rounded-t" | ||
src={`${product.imageUrl ? product.imageUrl : jordanBlackImage}`} | ||
alt="Jordan Black Shoes" | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alt 값도 수정이 필요해보입니다.
@@ -8,7 +8,7 @@ const TimeLabel = ({ time }: { time: number }) => { | |||
aria-label="시간" | |||
className={`absolute bottom-0 w-full pt-1 text-center bg-white opacity-80 ${color} border-b-2`} | |||
> | |||
{`${formattedTime}시간 남음`} | |||
{formattedTime === 0 ? null :`${formattedTime}시간 남음`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
제가 time이 0이되면 경매 종료 문구로 바꿔놓겠습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
엇 넵넵
@@ -22,7 +22,7 @@ const ProductItem = ({ product, children }: { product: ProductProps; children: R | |||
<div className='flex flex-col'> | |||
<div className='w-full h-auto mb-4'> | |||
<div className='relative'> | |||
<img className='object-cover w-full h-[15rem] rounded-t' src={`${product.cdnPath ? product.cdnPath : jordanBlackImage}`} alt='Jordan Black Shoes' /> | |||
<img className='object-cover w-full h-[15rem] rounded-t' src={`${product.imageUrl ? product.imageUrl : jordanBlackImage}`} alt='Jordan Black Shoes' /> | |||
{product.timeRemaining && <TimeLabel time={product.timeRemaining} />} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기도 위와 마찬가지로 Default image필요없을 것 같습니다.
@@ -32,7 +32,7 @@ const OrderLostProduct = ({ product }: { product: IUserAuctionLostItem }) => { | |||
<LuUsers className='text-gray-500' /> | |||
<p className='text-sm text-gray-500'>가장 높은 금액</p> | |||
</div> | |||
<p className='ml-4 font-semibold'>{`${(product.highestBid).toLocaleString()}원`}</p> | |||
<p className='ml-4 font-semibold'>{`${(product.highestAmount).toLocaleString()}원`}</p> | |||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
숫자를 원으로 바꾸는 함수를 util 함수에 작성해놨으니 그거 사용하시면 됩니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵!
@@ -18,7 +18,7 @@ const OrderWonProduct = ({ product }: { product: IUserAuctionWonItem }) => { | |||
<IoPricetagsOutline className='text-gray-500' /> | |||
<p className='text-sm text-gray-500'>시작가</p> | |||
</div> | |||
<p className='ml-4 font-semibold'>{`${product.minPrice.toLocaleString()}원`}</p> | |||
<p className='ml-4 font-semibold'>{`${product.minPrice ? product.minPrice.toLocaleString() : 'N/A'}원`}</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
숫자를 원으로 바꾸는 함수를 util 함수에 작성해놨으니 그거 사용하시면 됩니다.
@@ -32,7 +32,7 @@ const OrderWonProduct = ({ product }: { product: IUserAuctionWonItem }) => { | |||
<LuUsers className='text-gray-500' /> | |||
<p className='text-sm text-gray-500'>최종 낙찰금액</p> | |||
</div> | |||
<p className='ml-4 font-semibold'>{`${(product.winningBid).toLocaleString()}원`}</p> | |||
<p className='ml-4 font-semibold'>{`${product.winningAmount.toLocaleString()}원`}</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
숫자를 원으로 바꾸는 함수를 util 함수에 작성해놨으니 그거 사용하시면 됩니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인했습니다.
src/constants/route.ts
Outdated
@@ -18,7 +18,7 @@ const ROUTERS = Object.freeze({ | |||
ITEM: '/auctions/pre-auction', | |||
EDIT: '/auctions/pre-auction/edit', | |||
}, | |||
ADDRESSBOOK: '/addressbook', | |||
ADDRESSBOOK: '/shipping', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
라우터는 이거아니었나요?? /auctions/{auctionId}/shipping
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아 그렇네요!
💡 작업 내용
💡 자세한 설명
🛠️ ProductItem 시간, style, Type 변경
🛠️ 프로필 사진 추가
🛠️ 로그아웃 시 리프레시 만료될때 에러 해결
📗 참고 자료 (선택)
📢 리뷰 요구 사항 (선택)
🚩 후속 작업 (선택)
✅ 셀프 체크리스트
closes #이슈번호