Unique name value in library.properties #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Libraries having the same name value as the stock Arduino library in library.properties causes the libraries to always appear as type Updatable in Library Manager.
per1234
changed the title
|
I have reworked this PR to be minimally invasive while still fixing the issue of always updatable libraries. |
pico--
added a commit
that referenced
this pull request
Jan 31, 2016
Unique name value in library.properties
|
Merged. Thanks, Per. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a problem with some of the bundled libraries and the Arduino IDE Library Manager.
SD, Servo, and Firmata libraries were appearing as Updatable in Library Manager, and triggering updatable library notifications in Arduino IDE 1.6.6+, whenever a Mighty 1284P board was selected because they have the same name value(because if no library.properties file is present then the folder name is used). I used version 1.0.0 in library.properties for SD, Servo, and SDfat libraries because I was unable to determine which version they were based on.
This issue exacerbates #24 because it can cause the user to unnecessarily install the unpatched libraries to their {sketchbook}/libraries folder. This is especially likely with Arduino IDE versions 1.6.6+ because of the updatable library notifications.