New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BugFix: #69 precision bug #70

Open

lxzmxl wants to merge 1 commit into JCash:dev from lxzmxl:dev

lxzmxl commented Nov 27, 2022

#69 bugfix


          BugFix: JCash#69 precision bug

7d44dd4

Owner

JCash commented Nov 27, 2022

I'm sorry, but it seems you've got this the wrong way around.
The defines are there so that you can change them, without needing a PR.

See the documentation here:

#define JC_VORONOI_IMPLEMENTATION
#define JCV_REAL_TYPE double
#define JCV_ATAN2 atan2
#define JCV_SQRT sqrt
#define JCV_FLT_MAX DBL_MAX
#define JCV_PI 3.141592653589793115997963468544185161590576171875
//define JCV_EDGE_INTERSECT_THRESHOLD 1.0e-10F
#include "jc_voronoi.h"

Also, it's not good practice to change someone elses formatting.
E.g. I don't use clang format, so please use the style in the file.

And the unit tests are failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet