Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge py-pandas, py-awscrt, texinfo, and ectrans bug fixes from release/1.5.1 (with mods from spack develop) #831

Merged

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Oct 16, 2023

Summary

This PR brings the bug fixes for the packages listed above that went into release/1.5.1 first down to develop. There is a small update that is due to the modifications from spack develop (see JCSDA/spack#346 for the glorious details), namely the addition of the excel variant for py-pandas.

Note that we need to stick with [email protected] for a while, because I encountered build problems on my macOS with newer versions due to some complicated py-numba-llvm compiler dependencies.

Testing

  • @climbfuji's macOS
  • CI (ignore the failing container test, this is post-build when it is trying to post a message on the JCSDA CI slack channel, I haven't figured out why this works sometimes and sometimes not

Applications affected

JEDI applications, although py-pandas+excel is really only used in jedi-tools-env.

Systems affected

All systems that install the unified environment.

Dependencies

Issue(s) addressed

All Github issues were resolved when merging the updates into release/1.5.1, this is just bringing the improved and spack-sanctioned versions into develop. However, this PR does solve the current container CI failures for the Intel container (these run only twice a week on a nightly schedule using develop, errors are reported to the CI slack channel in the JCSDA workspace; see https://github.com/JCSDA/spack-stack/actions/runs/6516462554 for an example of a failed Intel container build).

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@climbfuji climbfuji enabled auto-merge October 18, 2023 16:25
@climbfuji climbfuji mentioned this pull request Oct 18, 2023
3 tasks
@climbfuji climbfuji disabled auto-merge October 18, 2023 17:48
@climbfuji climbfuji merged commit f3c9277 into JCSDA:develop Oct 18, 2023
5 checks passed
@climbfuji climbfuji deleted the feature/merge_openpyxl_etc_from_release_151 branch October 18, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INFRA JEDI Infrastructure
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants