Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependencies to ccpp-scm template, add Python build utilities to base-env #1466

Merged
merged 5 commits into from
Jan 22, 2025

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Jan 21, 2025

Summary

  1. Add missing dependencies py-numpy and py-netcdf4 to the CCPP SCM template
  2. Add essential Python build utilities py-wheel, py-setuptools, and py-setuptools-scm to base-env. These packages are already included in our environments, because they are basic build packages for many Python packages we build, but the modules weren't loaded automatically. This update makes sure tha the modules are loaded and available whenever base-env is loaded (explicitly or automatically as a dependency).

Testing

  • Built CCPP SCM environment on Atlantis with %oneapi, compiled SCM and ran one SCM test case
  • CI

Applications affected

CCPP SCM

Systems affected

None

Dependencies

None

Issue(s) addressed

Resolves #1461
Resolves #1460

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

configs/common/packages.yaml Outdated Show resolved Hide resolved
spack Outdated Show resolved Hide resolved
@climbfuji climbfuji marked this pull request as ready for review January 21, 2025 22:22
Copy link

@rickgrubin-tomorrow rickgrubin-tomorrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@climbfuji climbfuji enabled auto-merge (squash) January 22, 2025 12:24
@climbfuji climbfuji merged commit 31ccf49 into JCSDA:develop Jan 22, 2025
9 checks passed
@climbfuji climbfuji deleted the bugfixes/scm_cdo_py-netcdf4 branch January 22, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ccpp-scm template is missing dependencies Ad py-wheel as explicit dependency to base-env
3 participants