Fix 4 problems in mon_data_space and map-scatter plots #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix stuff.
EdwardSafford-NOAA
requested review from
CoryMartin-NOAA,
ADCollard and
kevindougherty-noaa
CoryMartin-NOAA
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes these problems:
mon_data_space.pynow adds empty lat and lon values for each level when the requested data file is not found. A value of1was used heretofore, which somehow worked. It does not work with code built on Rocky8 though, hence this change.emcpy_map_scatter.pynow removes 'level' from the plot object -- emcpy doesn't recognize level and fails if it's in the plot object's configuration. How this ever worked is not clear to me, but it does with this change.dynamic_config.pynow has a check on the data before it tries to sort the data. Without this check when there was no data an exception resulted.map_scatter.pynow includeslevelwhen selecting the specific data for a plot. Without this change only plots with a single level worked; all others had a dimension mismatch and resulting exception in the color bar generation. This one was totally my fault -- I installed a similar fix inline_plot.pymonths ago and asked myself if I needed to change any other plots? Nah, don't think so. Ooops.Close #205