-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check on control file and graceful exit, #196
Conversation
For the CI test failure is it a consensus that we need to bump the emcpy version (now at 9b6756341e)? And if so to which version? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@kevindougherty-noaa do you know the answer to this? |
Good question. I will have new PR for EMCPy next week with some changes needed for the documentation plus some minor changes. |
@CoryMartin-NOAA CI tests have passed so this is good to go now. |
#198) Add zeroed data if a station data file is missing to ensure continued execution. Resolves #197 ## Dependencies Not a huge deal but I started this branch from my fix for #196 so that should be merged before this change. --------- Co-authored-by: Cory Martin <[email protected]>
Modity
mon_data_space.py
adding a check on the control file and graceful exit if not found. Without this exit the entire plot job terminates. With this exit only the affected thread halts (with error message), allowing all other plots to proceed.This has been tested on wcoss2 by removing some control files from the test data set. Missing control files are reported as warnings and all plots with valid control files run to completion.
Dependencies
None
Resolves #191 .