Skip to content

Commit

Permalink
Add coding norms test (#3)
Browse files Browse the repository at this point in the history
* Add coding norms test

* update requirements

* add badge to readme

Co-authored-by: danholdaway <[email protected]>
  • Loading branch information
danholdaway and danholdaway authored Feb 2, 2022
1 parent 2a8499b commit 3c08671
Show file tree
Hide file tree
Showing 6 changed files with 57 additions and 3 deletions.
29 changes: 29 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
## Description

*(Instructions: replace text in this and all sections with your own text)*

Provide a detailed description of what this PR does.

What problem does it fix? What new capability does it add?

### Issue(s) addressed

- fixes #<issue_number>

## Acceptance Criteria (Definition of Done)

What does it mean for this PR to be finished?

## Dependencies

If there are PRs that need to be merged before or along with this one, please list them below
Waiting on the following PRs:
- [ ] waiting on org/repo/pull/<pr_number>
- [ ] waiting on org/repo/pull/<pr_number>

## Impact

Please list the other repositories (if any) that this PR will require changes in (example below)

- [ ] repo
- [ ] ...
18 changes: 18 additions & 0 deletions .github/workflows/codestyle.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
name: Coding Norms

on:
pull_request:
types: [opened, synchronize, reopened]

jobs:
pycodestyle:
name: Check Python Coding Norms
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-python@v2
with:
python-version: '3.9'
cache: 'pip'
- run: pip install -r requirements.txt
- run: python3 pycodestyle_run.py
6 changes: 5 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@

# Evaluation and Verification of the Analysis (EVA)

### Continuous integration:

| Test | Status |
| --------- | --------|
| Python coding norms | ![Status](https://github.com/danholdaway/eva/actions/workflows/codestyle.yml/badge.svg) |

### Installation

Expand Down
4 changes: 4 additions & 0 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
pyyaml>=5.4
pycodestyle>=2.8.0
netCDF4>=1.5.7
matplotlib>=3.4.3
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
'Operating System :: OS Independent'],
python_requires='>=3.6',
install_requires=[
'pyyaml>=5.3.1',
'pyyaml>=5.4',
'pycodestyle>=2.8.0',
'netCDF4>=1.5.7',
'matplotlib>=3.4.3',
Expand Down
1 change: 0 additions & 1 deletion src/eva/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,6 @@ def main():
'by the configuration file [madatory]. E.g. eva ObsCorrelationScatter ' +
'conf.yaml')


args = parser.parse_args()
args_list = args.args

Expand Down

0 comments on commit 3c08671

Please sign in to comment.