This repository has been archived by the owner on Apr 12, 2023. It is now read-only.
Added Starwars Dashboard with pagination #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@divyanshu-rawat Thanks for all the suggestions, this really helps me as I am new to React so I get to know better practices :) Will fix itall now 😄 |
xatuke
force-pushed
the
paginate-task
branch
2 times, most recently
from
d98b7a4
to
6d7ef40
Compare
Made requested changes :) Made requested changes by Anukriti Improved UX
xatuke
force-pushed
the
paginate-task
branch
from
fe2be5b
to
da5626a
Compare
|
let me know, if I should raise another PR as I see you have merged and reverted this one. @anukritijha |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Added a Dashboard which shows starwars data and you can paginate throught it.
Screenshots:
DEMO