Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation with C++17 #90

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Fix compilation with C++17 #90

merged 1 commit into from
Oct 11, 2024

Conversation

MrHands
Copy link
Contributor

@MrHands MrHands commented Oct 10, 2024

I'm integrating your project into my game, and unfortunately, it's stuck on C++17 for a bit longer. I found that compilation fails on the list header because named parameters are a C++20 feature. However, this is the only place in the codebase that explicitly uses a C++20 feature, so I felt it justified to downgrade it to C++17 for now. I want to upgrade my game to C++20 soon, so feel free to reject this PR if it doesn't align with your vision for the project. I also found a compile warning related to an implicit cast to ink::size_t in the string implementation when using STL, so I fixed that and prettied-up the whitespace.

@JBenda
Copy link
Owner

JBenda commented Oct 11, 2024

This is a good point. Iff at any point the resolution code uses concept's we can go back to C++20.

Thanks for spotting the size_t thing.

Good luck with your project, if you need ink related help there is the inkle Discord
https://discord.gg/inkle.

If you find more feel free to open more PRs.

@JBenda JBenda merged commit 8210a41 into JBenda:master Oct 11, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants