Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm integrating your project into my game, and unfortunately, it's stuck on C++17 for a bit longer. I found that compilation fails on the list header because named parameters are a C++20 feature. However, this is the only place in the codebase that explicitly uses a C++20 feature, so I felt it justified to downgrade it to C++17 for now. I want to upgrade my game to C++20 soon, so feel free to reject this PR if it doesn't align with your vision for the project. I also found a compile warning related to an implicit cast to
ink::size_t
in the string implementation when using STL, so I fixed that and prettied-up the whitespace.