Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TVTDragManager.GetDataObject() should not use TVTDataObject in case the OnCreateDataObject event handler returned nil #736

Closed
joachimmarder opened this issue Oct 26, 2017 · 0 comments
Closed

TVTDragManager.GetDataObject() should not use TVTDataObject in case the OnCreateDataObject event handler returned nil #736

joachimmarder opened this issue Oct 26, 2017 · 0 comments
Assignees
@joachimmarder
Labels
Breaking Change Open for Discussion There are several possibilites to address the issue and anyone is invited for comments.
Milestone
V7.0

Comments

@joachimmarder
Copy link
Contributor

TVTDragManager.GetDataObject() should not fall back to TVTDataObject in case the OnCreateDataObject event handler actively decided to return nil, it should do that only in case no OnCreateDataObject event handler is assigned. In some situations the creation of an IDataObject simply fails with an error, and there is nothing to drag (maybe because the object is already deleted).

It is currently very inconvenient to interrupt the started drag operation once you recognized that you cannot provide an IDataObject.
@joachimmarder joachimmarder self-assigned this Oct 26, 2017
@joachimmarder joachimmarder added Breaking Change Open for Discussion There are several possibilites to address the issue and anyone is invited for comments. labels Oct 26, 2017
@joachimmarder joachimmarder added this to the V7.0 milestone Mar 17, 2018
joachimmarder pushed a commit that referenced this issue Jun 12, 2018
Fixed issue #736: TVTDragManager.GetDataObject() should not use TVTDa…
e5e4d2a 
…taObject in case the OnCreateDataObject event handler returned nil
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joachimmarder joachimmarder

Labels
Breaking Change Open for Discussion There are several possibilites to address the issue and anyone is invited for comments.
Projects
None yet
Milestone
V7.0
Development

No branches or pull requests
1 participant
@joachimmarder