Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A review of all Demos is needed to fix GetText, GetHint, etc to assign in DFM instead of assigning in FormCreate #720

Closed
sanjayssk opened this issue May 12, 2017 · 0 comments
Closed

A review of all Demos is needed to fix GetText, GetHint, etc to assign in DFM instead of assigning in FormCreate #720

sanjayssk opened this issue May 12, 2017 · 0 comments
Assignees
@sanjayssk
Labels
Open for Discussion There are several possibilites to address the issue and anyone is invited for comments.
Milestone
V6.7

Comments

@sanjayssk
Copy link
Contributor

Now that we support only XE3 and higher, some code in the Demos is irrelevant and confusing. For example, in many demos, the OnGetText event is assigned in code to be compatible with the older Delphi versions with this comment:

// We assign the OnGetText handler manually to keep the demo source code compatible
// with older Delphi versions after using UnicodeString instead of WideString.

I think all these should be removed and the standard event links in DFM should be made to OnGetText.
@joachimmarder joachimmarder added this to the V6.7 milestone May 12, 2017
@sanjayssk sanjayssk added the Open for Discussion There are several possibilites to address the issue and anyone is invited for comments. label May 13, 2017
@sanjayssk sanjayssk changed the title A review of all Demos is needed A review of all Demos is needed to fix GetText, GetHint, etc to assign in DFM instead of assigning in FormCreate May 26, 2017
sanjayssk added a commit that referenced this issue May 26, 2017
@sanjayssk
Fixed issue #720: A review of all Demos is needed to fix GetText, Get…
d00bfc4 
…Hint, etc to assign in DFM instead of assigning in FormCreate

* The events were changed to match the event signatures with "string" instead of Unicode
* Parameter names for text were also changed as per those in VirtualTrees
* Made sure that Object Inspector could assign events
* Tested all demos after the fix
* Also fixed the search path in Interfaces demo project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sanjayssk sanjayssk

Labels
Open for Discussion There are several possibilites to address the issue and anyone is invited for comments.
Projects
None yet
Milestone
V6.7
Development

No branches or pull requests
2 participants
@joachimmarder @sanjayssk