Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if DragMode is dmAutomatic then the OnChange event is fired twice when clicking a selected node #694

Closed
joachimmarder opened this issue Feb 21, 2017 · 0 comments
Closed

if DragMode is dmAutomatic then the OnChange event is fired twice when clicking a selected node #694

joachimmarder opened this issue Feb 21, 2017 · 0 comments
Assignees
@joachimmarder
Labels
Bug

Comments

@joachimmarder
Copy link
Contributor

joachimmarder commented Feb 21, 2017 •
edited
Loading

if DragMode is dmAutomatic then the OnChange event is fired twice when clicking an already selected node, once with nil and then again with the clicked node. It makes no sense to clear the selection if the clicked node is already selected.

Repro steps:

  • Open the Advanced.dproj
  • Open the SpeedDemo unit
  • in the Virtual TreeView set DragMode to dmAutomatic
  • Set a brekapoint in TSpeedForm.VST1Change()
  • Click an already clicked node
  • => The event is fired with Node == nil
@joachimmarder joachimmarder self-assigned this Feb 21, 2017
joachimmarder pushed a commit that referenced this issue Feb 23, 2017
* Improved fix for issue #690
ec85030 
* Added fix for #694 (if DragMode is dmAutomatic then the OnChange event is fired twice when clicking a selected node)
ValtsS pushed a commit to ValtsS/Virtual-TreeView that referenced this issue Jan 25, 2019
@ValtsS
* Improved fix for issue JAM-Software#690
c0b3040 
* Added fix for JAM-Software#694 (if DragMode is dmAutomatic then the OnChange event is fired twice when clicking a selected node)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joachimmarder joachimmarder

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joachimmarder