Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HintMode hmHintAndDefault: If the BidiMode is right to left, the Default Hint fails to appear #674

Closed
sanjayssk opened this issue Nov 26, 2016 · 0 comments
Closed

HintMode hmHintAndDefault: If the BidiMode is right to left, the Default Hint fails to appear #674

sanjayssk opened this issue Nov 26, 2016 · 0 comments
Assignees
@sanjayssk
Labels
Bug

Comments

@sanjayssk
Copy link
Contributor

In exactly the same conditions as in Issue 289, the BidiMode is made right to left, the Default Hint fails to appear. The reason for this is seems to be that the columns are right-aligned and the function GetColumnAndBounds returns column 0 on the left side where no columns are present. This is wrong. I found this when fixing the issue 289. However, since this function is used in many places, it has to be inspected very carefully before fixing.
@sanjayssk sanjayssk self-assigned this Nov 26, 2016
@sanjayssk sanjayssk added the Bug label Nov 28, 2016
sanjayssk pushed a commit that referenced this issue Nov 28, 2016
Fixed issue #674: HintMode hmHintAndDefault: If the BidiMode is right…
37dbc27 
… to left, the Default Hint fails to appear

The loop in GetColumnAndBounds didn't account for right to left bidimode. Fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sanjayssk sanjayssk

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sanjayssk