Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag and drop header, more problems #658

Closed
sanjayssk opened this issue Sep 15, 2016 · 1 comment
Closed

Drag and drop header, more problems #658

sanjayssk opened this issue Sep 15, 2016 · 1 comment
Assignees

Comments

@sanjayssk
Copy link
Contributor

I found some new bugs related to drag and drop of header.

  1. Drag a header entirely across the header area and don't move the mouse after a drop. The repaint does not occur and you might see old column name till you move the mouse.

  2. Drag a header from column 3 to column 1 beginning (entirely over the header). The left drop mark appears on column 1 but when you drop, the actual drop does not occur. If you do the same operation over the columns area, it works.

Commented my earlier fixes in #248 and #643 just to see if they caused any of these problems. But the problems still occur.

@sanjayssk sanjayssk self-assigned this Sep 20, 2016
@sanjayssk
Copy link
Contributor Author

Problem 1 is a timing issue where the BitBlt of the drag object is slower than the painting of the changed header that occurs after it with the result that what you see after the drop is the backup image instead of the changed columns. When you move the mouse away from the header, it's repainted again. This problem seems to occur only on a certain graphics adapter on Windows 10. Will fix this if the fix seems simple enough so as not to disturb anything else.

Problem 2 is a case of detection of the drag as a drag out and so column change does not occur. But the fact that the drop mark appears and is not honored is not a correct behavior. Will need to investigate some more to see if it is worth solving.

sanjayssk pushed a commit that referenced this issue Sep 20, 2016
… in certain conditions

* The conditions are, drag is across header, mouse is not moved after the drop and the graphics hardware is slow in certain operations
* The fix involved introducing a small delay after the EndDrag so that the new header is not overlapped by the backup image of TVTDragImage.
* Complete details are in the comments of the code.
ValtsS pushed a commit to ValtsS/Virtual-TreeView that referenced this issue Jan 25, 2019
…after a drop in certain conditions

* The conditions are, drag is across header, mouse is not moved after the drop and the graphics hardware is slow in certain operations
* The fix involved introducing a small delay after the EndDrag so that the new header is not overlapped by the backup image of TVTDragImage.
* Complete details are in the comments of the code.

# Conflicts:
#	CHANGES.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant