Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Added Italian translation, added strings to strings.xml and optimized… #781

Merged
merged 4 commits into from
Apr 24, 2022
Merged

Conversation

code-a1
Copy link
Contributor

@code-a1 code-a1 commented Apr 24, 2022

… a date for localization

Pull Request (PR) Checklist

Please check if your pull request fulfills the following requirements:

  • The PR is submitted to the develop branch.
  • I've read the Contribution Guidelines.
  • The code builds and is tested on an actual Android device.
  • I confirm that I've run the code locally and everything works as expected.
  • I confirm that I've run Ivy Wallet's UI tests (androidTest) and all tests are passing
    successfully.

Important: Don't worry if you experience flaky UI tests. Just re-run the failed ones again and if they pass => it's all good!

Put an x in the boxes that apply.

  • Demo: Checking checkbox using [x]

Pull Request Type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, new lines, etc.)
  • Refactoring (no functional changes, renaming)
  • Small improvement (fix typo, UI fine-tune, change color or something small)
  • Gradle Build related changes
  • Dependencies update (updating libraries)
  • Documentation (clarifying comments, KDoc)
  • Tests (Unit, Integration, UI tests)
  • Other (please describe):

Put an x in the boxes that apply.

Does this PR closes any GitHub Issues?

Check Ivy Wallet Issues.

What's changed?

Describe with a few bullets what's new:

  • Added Italian translation
  • Added strings to strings.xml
  • Optimized a couple of dates for a better localisation
  • Fixed a typo in strings.xml

How to run Ivy Wallet's UI tests (androidTest)

Connect Android Emulator

  • Pixel 5 API 29+ AVD emulator (recommended)
  • Pixel 3XL API 29+ AVD emulator (recommended)
  • Large screen physical device (might also work)

Method 1: Android Studio UI

  • Find com (androidTest) package
  • Right click
  • Run 'Tests in 'com''

Note: If you've checked "Compact Middle Packages" the option will appear as com.ivy.wallet (androidTest).

Method 2: Gradle Wrapper

  • chmod +x gradlew (Linux)
  • ./gradlew connectedDebugAndroidTest

Method 3: Fastlane

  • Install Ruby 2.7
  • bundle install
  • bundle exec fastlane ui_tests

@StarHamster StarHamster linked an issue Apr 24, 2022 that may be closed by this pull request
@ILIYANGERMANOV
Copy link
Collaborator

Hi @code-a1, your PR is good and I'm happy to merge it! However, after the merging of architecture, it has some conflicts. Can you resolve them?

@ILIYANGERMANOV ILIYANGERMANOV merged commit 8a136ce into Ivy-Apps:develop Apr 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TRANSLATION] Italian
2 participants