Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Fix issue 3637 #3647

Merged
merged 10 commits into from
Oct 25, 2024
Merged

Fix issue 3637 #3647

merged 10 commits into from
Oct 25, 2024

Conversation

viratde
Copy link
Contributor

@viratde viratde commented Oct 25, 2024

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

  • [ x] I've read the Contribution Guidelines and my PR doesn't break the rules.
  • [ x] I've read and understand the Developer Guidelines.
  • [ x] I confirm that I've run the code locally and everything works as expected.
  • [x ] My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
  • [ x] 🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

What's changed?

Describe with a few bullets what's new:

  • I've fixed accounts specific colors not shwoing in transferheader

Before|After
Screenshot_2024-10-25-08-49-25-58_25a5cbee76b0e8af12aa5b9c322cd4a3
|
Screenshot_2024-10-25-09-03-28-71_25a5cbee76b0e8af12aa5b9c322cd4a3

Risk factors

What may go wrong if we merge your PR?
Nothing

In what cases won't your code work?

Does this PR close any GitHub issues? (do not delete)

Troubleshooting GitHub Actions (CI) failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

ILIYANGERMANOV
ILIYANGERMANOV suggested changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! The gradient looks good 💯 Left some comments

.idea/appInsightsSettings.xml Outdated Show resolved Hide resolved
temp/legacy-code/src/main/java/com/ivy/legacy/ui/component/transaction/TransactionCard.kt Outdated Show resolved Hide resolved
shared/base/src/main/java/com/ivy/base/Constants.kt Outdated Show resolved Hide resolved
@ILIYANGERMANOV ILIYANGERMANOV added keep Keep it from automatically getting closed by Stale requested changes Changes are needed. Please, apply them labels Oct 25, 2024
Made Changed Based On Feedback, Added ide conf files in gitignore and…
f37139e 
… Added Private constant in the composable also
ILIYANGERMANOV
ILIYANGERMANOV suggested changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be no .idea files changes

temp/legacy-code/src/main/java/com/ivy/legacy/ui/component/transaction/TransactionCard.kt Outdated Show resolved Hide resolved
.idea/inspectionProfiles/Project_Default.xml Outdated Show resolved Hide resolved
.idea/runConfigurations.xml Outdated Show resolved Hide resolved
temp/legacy-code/src/main/java/com/ivy/legacy/ui/component/transaction/TransactionCard.kt Outdated Show resolved Hide resolved
ILIYANGERMANOV
ILIYANGERMANOV suggested changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be no changes in .idea , other than that looks good

.idea/appInsightsSettings.xml Outdated Show resolved Hide resolved
.idea/inspectionProfiles/Project_Default.xml Outdated Show resolved Hide resolved
.idea/runConfigurations.xml Outdated Show resolved Hide resolved
@ILIYANGERMANOV ILIYANGERMANOV added ready to merge 🚀 PR can be merged after the CI pass and removed requested changes Changes are needed. Please, apply them labels Oct 25, 2024
@ILIYANGERMANOV ILIYANGERMANOV merged commit 0e112f2 into Ivy-Apps:main Oct 25, 2024
9 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ILIYANGERMANOV ILIYANGERMANOV ILIYANGERMANOV approved these changes

Assignees
No one assigned
Labels
keep Keep it from automatically getting closed by Stale ready to merge 🚀 PR can be merged after the CI pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add color to transfer label in transaction list
2 participants
@viratde @ILIYANGERMANOV