Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Added Support For Large Number Formatting(Thousand, Million, Billion) in FormatMoneyUseCase #3634

Merged
merged 5 commits into from
Oct 21, 2024
Merged

Added Support For Large Number Formatting(Thousand, Million, Billion) in FormatMoneyUseCase #3634

merged 5 commits into from
Oct 21, 2024

Conversation

shamim-emon
Copy link
Member

@shamim-emon shamim-emon commented Oct 20, 2024 •
edited
Loading

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

  • I've read the Contribution Guidelines and my PR doesn't break the rules.
  • I've read and understand the Developer Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
  • 🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

Screen recording of your changes (if applicable):

What's changed?

Describe with a few bullets what's new:

  • I've added Formatting support for large number(Million, Billion) in FormatMoneyUseCase

Risk factors

What may go wrong if we merge your PR?

  • N/A

In what cases won't your code work?

  • N/A

Does this PR close any GitHub issues? (do not delete)

Troubleshooting GitHub Actions (CI) failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

@ILIYANGERMANOV ILIYANGERMANOV added the requested changes Changes are needed. Please, apply them label Oct 20, 2024
ILIYANGERMANOV
ILIYANGERMANOV suggested changes Oct 20, 2024
View reviewed changes
Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How the app is compiling? I guess that this use-case isn't used anywhere

shared/ui/core/src/main/java/com/ivy/ui/FormatMoneyUseCase.kt Outdated Show resolved Hide resolved
shared/ui/core/src/test/java/com/ivy/ui/FormatMoneyUseCaseTest.kt Outdated Show resolved Hide resolved
shared/ui/core/src/test/java/com/ivy/ui/FormatMoneyUseCaseTest.kt Outdated Show resolved Hide resolved
ILIYANGERMANOV
ILIYANGERMANOV suggested changes Oct 20, 2024
View reviewed changes
Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed more in detail and added some comments, ping me for re-review when ready

shared/ui/core/src/main/java/com/ivy/ui/FormatMoneyUseCase.kt Outdated Show resolved Hide resolved
shared/ui/core/src/main/java/com/ivy/ui/FormatMoneyUseCase.kt Outdated Show resolved Hide resolved
shared/ui/core/src/test/java/com/ivy/ui/FormatMoneyUseCaseTest.kt Outdated Show resolved Hide resolved
shared/ui/core/src/test/java/com/ivy/ui/FormatMoneyUseCaseTest.kt Outdated Show resolved Hide resolved
shared/ui/core/src/test/java/com/ivy/ui/FormatMoneyUseCaseTest.kt Show resolved Hide resolved
shared/ui/core/src/main/java/com/ivy/ui/FormatMoneyUseCase.kt Outdated Show resolved Hide resolved
shared/ui/core/src/main/java/com/ivy/ui/FormatMoneyUseCase.kt Show resolved Hide resolved
@shamim-emon
Added Support For Large Number Formatting(Million, Billion,thousands)…
7e77909 
… in FormatMoneyUseCase - refactored FormatMoneyUseCase + updated related unit tests
ILIYANGERMANOV
ILIYANGERMANOV suggested changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replied to your comments

@shamim-emon
Added Support For Large Number Formatting(Million, Billion,thousands)…
0469876 
… in FormatMoneyUseCase - added shortenAmountFormatter
@shamim-emon shamim-emon changed the title Added Support For Large Number Formatting(Million, Billion) in FormatMoneyUseCase Added Support For Large Number Formatting(Thousand, Million, Billion) in FormatMoneyUseCase Oct 21, 2024
@ILIYANGERMANOV ILIYANGERMANOV merged commit c1ca2b9 into Ivy-Apps:main Oct 21, 2024
9 checks passed
@shamim-emon shamim-emon deleted the fix-issue-3633 branch October 21, 2024 13:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ILIYANGERMANOV ILIYANGERMANOV ILIYANGERMANOV approved these changes

Assignees
No one assigned
Labels
requested changes Changes are needed. Please, apply them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Support For Large Number
2 participants
@shamim-emon @ILIYANGERMANOV