Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deletion dialog incorrectly reappearing bug #3620

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

p42rthicle
Copy link
Contributor

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

  • I've read the Contribution Guidelines and my PR doesn't break the rules.
  • I've read and understand the Developer Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
  • 🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

Screen recording of your changes (if applicable):

deletion_dialog_bug_fix.mp4

What's changed?

The dialog doesn't reappear now

Describe with a few bullets what's new:

  • I've fixed dialog visibility state not reset after confirm deletion of account

Risk factors

  • N/A
    What may go wrong if we merge your PR?
  • N/A

Does this PR close any GitHub issues? (do not delete)

Troubleshooting GitHub Actions (CI) failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ILIYANGERMANOV ILIYANGERMANOV added the ready to merge 🚀 PR can be merged after the CI pass label Oct 14, 2024
@ILIYANGERMANOV ILIYANGERMANOV merged commit 7d81724 into Ivy-Apps:main Oct 14, 2024
9 checks passed
@p42rthicle p42rthicle deleted the fix-issue-3616 branch October 15, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge 🚀 PR can be merged after the CI pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Delete Dialog Incorrectly reappears
2 participants