Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Add horizontal swipe gesture to loans screen #3604

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

p42rthicle
Copy link
Contributor

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

  • I've read the Contribution Guidelines and my PR doesn't break the rules.
  • I've read and understand the Developer Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
  • 🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

Screen recording of the changes:

LoansScreen.horizontal.swipe.Ivy.Wallet.Debug.mp4

What's changed?

Describe with a few bullets what's new:

  • I've added horizontal swipe support to the loan screen just like the home screen
Before After
No horizontal swipe Horizontal swipe ✅

Risk factors

What may go wrong if we merge your PR?

  • These changes aren't dangerous.

Does this PR close any GitHub issues?

Troubleshooting GitHub Actions (CI) failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

@ILIYANGERMANOV ILIYANGERMANOV added the ready to merge 🚀 PR can be merged after the CI pass label Oct 12, 2024
@p42rthicle
Copy link
Contributor Author

Is the lint check failing because of some resource 'not used' warnings that we get?

@p42rthicle p42rthicle closed this Oct 12, 2024
@p42rthicle p42rthicle reopened this Oct 12, 2024
@p42rthicle
Copy link
Contributor Author

Closed by mistake, my bad

@ILIYANGERMANOV ILIYANGERMANOV merged commit 3479e35 into Ivy-Apps:main Oct 12, 2024
17 of 18 checks passed
@p42rthicle p42rthicle deleted the fix-issue-3589 branch October 12, 2024 22:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready to merge 🚀 PR can be merged after the CI pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Loan screen horizontal swipe gesture
2 participants