Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

strings.xml improvements and small rephrasals #3578

Merged
merged 5 commits into from
Oct 4, 2024

Conversation

nvllz
Copy link
Contributor

@nvllz nvllz commented Oct 3, 2024

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

  • I've read the Contribution Guidelines and my PR doesn't break the rules.
  • I've read and understand the Developer Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
  • 🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

What's changed?

Describe with a few bullets what's new:

  • tried to make some strings more user friendly
  • fixed grammar/spelling errors

Does this PR close any GitHub issues? (do not delete)

  • Closes N/A

@nvllz nvllz requested a review from ILIYANGERMANOV as a code owner October 3, 2024 12:04
Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements! Merging after the CI pass

@ILIYANGERMANOV
Copy link
Collaborator

@nvllz you need to update the screenshot tests because you modified an UI see the CI Troubleshooting guide

@nvllz
Copy link
Contributor Author

nvllz commented Oct 4, 2024

@ILIYANGERMANOV Is there a way to return all paparazzi errors at once? Or do I have to debug and record them one by one? I mean if I knew which screens to record I could easily do it in bulk, now I have to wait 7 minutes to know which next screen (you name it module in your docs/faq/guidelines) is gonna throw an error. Sorry for my ignorance, but this is overkill.

@ILIYANGERMANOV ILIYANGERMANOV merged commit 9ad86b9 into Ivy-Apps:main Oct 4, 2024
9 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants