-
Notifications
You must be signed in to change notification settings - Fork 720
[Feature] Added Decimal Formatting Capability #3568
Conversation
shared/ui/core/src/test/java/com/ivy/ui/FormatMoneyUseCaseTest.kt
Outdated
Show resolved
Hide resolved
@shamim-emon it's your Android Studio, all tests are passing on the CI. Sometimes Android Studio habe an incorrect run configuration and that's why it cannot run the test. Try running the test by clicking the play button on the entire package or the tesr class |
@ILIYANGERMANOV
my current unit test is failing with below error
I'm a little unsure about the underlying cause here. If possible give me some suggestion around it. |
shared/domain/src/main/java/com/ivy/domain/features/IvyFeatures.kt
Outdated
Show resolved
Hide resolved
shared/domain/src/main/java/com/ivy/domain/features/IvyFeatures.kt
Outdated
Show resolved
Hide resolved
shared/ui/core/src/test/java/com/ivy/ui/FormatMoneyUseCaseTest.kt
Outdated
Show resolved
Hide resolved
shared/ui/core/src/test/java/com/ivy/ui/FormatMoneyUseCaseTest.kt
Outdated
Show resolved
Hide resolved
8bd8fd4
to
88eee88
Compare
88eee88
to
7b6406b
Compare
@ILIYANGERMANOV I had to switch to |
shared/ui/core/src/test/java/com/ivy/ui/FormatMoneyUseCaseTest.kt
Outdated
Show resolved
Hide resolved
shared/ui/core/src/test/java/com/ivy/ui/FormatMoneyUseCaseTest.kt
Outdated
Show resolved
Hide resolved
shared/ui/core/src/test/java/com/ivy/ui/FormatMoneyUseCaseTest.kt
Outdated
Show resolved
Hide resolved
shared/ui/core/src/test/java/com/ivy/ui/FormatMoneyUseCaseTest.kt
Outdated
Show resolved
Hide resolved
shared/ui/core/src/test/java/com/ivy/ui/FormatMoneyUseCaseTest.kt
Outdated
Show resolved
Hide resolved
shared/ui/core/src/test/java/com/ivy/ui/FormatMoneyUseCaseTest.kt
Outdated
Show resolved
Hide resolved
@ILIYANGERMANOV I have resolved all reviews. Please let me know if anything else needed. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 💯
Pull request (PR) checklist
Please check if your pull request fulfills the following requirements:
Screen recording of your changes (if applicable):
What's changed?
Describe with a few bullets what's new:
Risk factors
What may go wrong if we merge your PR?
-N/A
In what cases won't your code work?
-N/A
Does this PR close any GitHub issues? (do not delete)
Troubleshooting GitHub Actions (CI) failures ❌
Pull request checks failing? Read our CI Troubleshooting guide.