Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Fixed font baseline alignment using baseline shift instead of padding workaround #355

Merged
merged 2 commits into from
Jan 2, 2022

Conversation

swapnilkadlag
Copy link
Contributor

Pull Request (PR) Checklist

Please check if your pull request fulfills the following requirements:

  • The PR is submitted to the develop branch.
  • I've read the Contribution Guidelines.
  • The code builds and is tested on an actual Android device.
  • I confirm that I've run the code locally and everything works as expected.
  • I confirm that I've run Ivy Wallet's UI tests (androidTest) and all tests are passing
    successfully.

Important: Don't worry if you experience flaky UI tests. Just re-run the failed ones again and if they pass => it's all good!

Pull Request Type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, new lines, etc.)
  • Refactoring (no functional changes, renaming)
  • Small improvement (fix typo, UI fine-tune, change color or something small)
  • Gradle Build related changes
  • Dependencies update (updating libraries)
  • Documentation (clarifying comments, KDoc)
  • Tests (Unit, Integration, UI tests)
  • Other (please describe):

Put an x in the boxes that apply.

Does this PR closes any GitHub Issues?

Check Ivy Wallet Issues.

What's changed?

  • Fixed font baseline alignment using baseline shift instead of padding workaround.

How to run Ivy Wallet's UI tests (androidTest)

Connect Android Emulator

  • Pixel 5 API 29+ AVD emulator (recommended)
  • Pixel 3XL API 29+ AVD emulator (recommended)
  • Large screen physical device (might also work)

Method 1: Android Studio UI

  • Find com (androidTest) package
  • Right click
  • Run 'Tests in 'com''

Note: If you've checked "Compact Middle Packages" the option will appear as com.ivy.wallet (androidTest).

Method 2: Gradle Wrapper

  • chmod +x gradlew (Linux)
  • ./gradlew connectedDebugAndroidTest

Method 3: Fastlane

  • Install Ruby 2.7
  • bundle install
  • bundle exec fastlane ui_tests

@swapnilkadlag
Copy link
Contributor Author

@ILIYANGERMANOV few UI tests are failing from PlannedPaymentsTest.

  • Onboard_CreatePlannedPaymentFromPrompt
  • AddSeveralPlannedPayments

Tests are probably failing due to unused startDate parameter, because of which 2 planned payments are added to the current month if next payment is also expected in the same month due to 4 week/28 day period

Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @swapnilkadlag your PR is good! I'll merge it. The failing tests are because of the reasons you mentioned -> I fixed them, too. Thanks for your contribution :)

Can you give me your LinkedIn profile so I can endorse you and give you an Ivy Wallet premium lifetime code?

@ILIYANGERMANOV ILIYANGERMANOV merged commit 1c0cac0 into Ivy-Apps:develop Jan 2, 2022
@swapnilkadlag
Copy link
Contributor Author

Thanks you @ILIYANGERMANOV , here you go -> www.linkedin.com/in/swapnilkadlag

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants