This repository has been archived by the owner on Nov 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 712
Search Functionality In Category Screen #3499
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ILIYANGERMANOV
suggested changes
Sep 13, 2024
shared/domain/src/main/java/com/ivy/domain/features/IvyFeatures.kt
Outdated
Show resolved
Hide resolved
screen/categories/src/main/java/com/ivy/categories/CategoriesScreen.kt
Outdated
Show resolved
Hide resolved
screen/categories/src/main/java/com/ivy/categories/CategoriesViewModel.kt
Outdated
Show resolved
Hide resolved
screen/categories/src/main/java/com/ivy/categories/CategoriesViewModel.kt
Outdated
Show resolved
Hide resolved
screen/categories/src/main/java/com/ivy/categories/CategoriesViewModel.kt
Outdated
Show resolved
Hide resolved
ILIYANGERMANOV
added
the
requested changes
Changes are needed. Please, apply them
label
Sep 13, 2024
ILIYANGERMANOV
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done 👏
shared/domain/src/main/java/com/ivy/domain/features/IvyFeatures.kt
Outdated
Show resolved
Hide resolved
@shinebrillant great work! As a feedback, try putting meaningful commit message describing the change in the commit briefly l:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request (PR) checklist
Please check if your pull request fulfills the following requirements:
Screen recording of your changes (if applicable):
What's changed?
Describe with a few bullets what's new:
Category Screen
Categoy.Screen.Search.Bar.mp4
Does this PR close any GitHub issues? (do not delete)
Troubleshooting GitHub Actions (CI) failures ❌
Pull request checks failing? Read our CI Troubleshooting guide.