This repository has been archived by the owner on Nov 5, 2024. It is now read-only.
feat: Add toggle for showing previous title suggestions in transactio… #3466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shared/domain/src/main/java/com/ivy/domain/features/IvyFeatures.kt
Outdated
Show resolved
Hide resolved
ILIYANGERMANOV
suggested changes
Sep 2, 2024
screen/edit-transaction/src/main/java/com/ivy/transaction/EditTransactionViewEvent.kt
Outdated
Show resolved
Hide resolved
screen/edit-transaction/src/main/java/com/ivy/transaction/EditTransactionViewModel.kt
Outdated
Show resolved
Hide resolved
There's an HTML file attached to the lint check in "Details". See it. Or run ./scripts/lint.sh |
ILIYANGERMANOV
suggested changes
Sep 2, 2024
screen/edit-transaction/src/main/java/com/ivy/transaction/EditTransactionViewModel.kt
Outdated
Show resolved
Hide resolved
screen/edit-transaction/src/main/java/com/ivy/transaction/EditTransactionViewModel.kt
Outdated
Show resolved
Hide resolved
screen/edit-transaction/src/main/java/com/ivy/transaction/EditTransactionViewModel.kt
Outdated
Show resolved
Hide resolved
|
@ILIYANGERMANOV it's ready to merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request (PR) checklist
Please check if your pull request fulfills the following requirements:
Screen recording of your changes (if applicable):
WhatsApp.Video.2024-09-02.at.17.55.44_acc1cc8b.mp4
What's changed?
Describe with a few bullets what's new:
Risk factors
What may go wrong if we merge your PR?
In what cases won't your code work?
Does this PR close any GitHub issues? (do not delete)
Troubleshooting GitHub Actions (CI) failures ❌
Pull request checks failing? Read our CI Troubleshooting guide.