Fix Incorrect Time Display After Saving Transaction #3433
Conversation
shamim-emon
changed the title
| @@ -704,7 +705,7 @@ class EditTransactionViewModel @Inject constructor( | |||
| dateTime = when { | |||
| loadedTransaction().dateTime == null && | |||
| dueDate.value == null -> { | |||
| timeNowUTC() | |||
| timeProvider.utcNow().atZone(timeProvider.getZoneId()).toLocalDateTime() | |||
There was a problem hiding this comment.
I tested it, the date is showing correctly after saving the transaction but the is issue in the balance calculation. the balance didnt get updated for me...
There was a problem hiding this comment.
Thank you @akashs056! Much appreciated that you tested 🙌
There was a problem hiding this comment.
@akashs056 thanks for pointing it out.
@ILIYANGERMANOV sure, since this will be a big task, can I create another issue and attach with this PR once goal is reached? |
Yeah that makes sense |
ILIYANGERMANOV
added
the
requested changes
|
@ILIYANGERMANOV @akashs056 will reopen PR once done with |
@shamim-emon I have errors in #3435 (the app crashes with Long overflow) and other stuff are broken. I'll see I'll easily fix them. Ideally, at one point we should rewrite the legacy properly and cover it with tests (like the new APIs) |
Pull request (PR) checklist
Please check if your pull request fulfills the following requirements:
Screen recording of your changes (if applicable):
What's changed?
Describe with a few bullets what's new:
Incorrect Time Display After Saving TransactionissueRisk factors
What may go wrong if we merge your PR?
In what cases won't your code work?
Does this PR close any GitHub issues? (do not delete)
Troubleshooting GitHub Actions (CI) failures ❌
Pull request checks failing? Read our CI Troubleshooting guide.