Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Stickyheader overlap fixes #2884

Merged
merged 4 commits into from
Jan 21, 2024
Merged

Conversation

nvllz
Copy link
Contributor

@nvllz nvllz commented Jan 21, 2024

Pull Request (PR) Checklist

Please check if your pull request fulfills the following requirements:

  • The PR is submitted to the main branch.
  • I've read the Contribution Guidelines and my PR doesn't break the "Contributing Rules".
  • I've read the Architecture Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • 🎬 I've attached a screen recoding of the changes.

What's changed?

Before After
before after

Describe with a few bullets what's new:

  • made stickyheader balance display in two rows
  • restored 4 asterisks on hidden balance rows
  • abbreviate months in stickyheader when displayed next to a year to make it shorter (not shown in comparison)

Risk Factors

What may go wrong if we merge your PR?

It probably won't work for everyone in every case, but this way we get a better handle on the sticky header.

Does this PR closes any GitHub Issues?

I'm sure this lint shit will prevent us from merging it directly, but let's try.. :D

@nvllz nvllz requested a review from ILIYANGERMANOV as a code owner January 21, 2024 18:48
@ILIYANGERMANOV
Copy link
Collaborator

Hey @nvllz add a baseline because of Detekt. The problem with the Detekt linter is that we have a lot of shitty legacy code. Overall, Detekt is really good and takes care about bad practices - unfortunately the legacy code is full of them and we pay the price 😀

@ILIYANGERMANOV
Copy link
Collaborator

@nvllz run:

./gradlew detekt

locally to quickly identify and fix the reported errors

@nvllz
Copy link
Contributor Author

nvllz commented Jan 21, 2024

Unfortunately this doesn't work for me, I'll read error messages here on github and try to make it work.

That's what I get inside Android Studio terminal:

FAILURE: Build failed with an exception.

* What went wrong:
Could not determine the dependencies of task ':buildSrc:compileKotlin'.
> Unknown Kotlin JVM target: 21

This stuff is sooo weird xd

@ILIYANGERMANOV
Copy link
Collaborator

Unfortunately this doesn't work for me, I'll read error messages here on github and try to make it work.

That's what I get inside Android Studio terminal:

FAILURE: Build failed with an exception.

* What went wrong:
Could not determine the dependencies of task ':buildSrc:compileKotlin'.
> Unknown Kotlin JVM target: 21

This stuff is sooo weird xd

Don't use the terminal. Try this:

  1. Click the Gradle elephant top right
  2. Click the first button (top-left) in the new window - where you can run Gradle commands
  3. Run detekt

You get this errors because your machine JDK isn't compatible with the Ivy Wallet's one. Running from Android Studio will fix it because it'll use the one bundled with Android Studio. Unfortunately, the scripts that I wrote are only compatible with Mac/Linux + proper Java version

@nvllz
Copy link
Contributor Author

nvllz commented Jan 21, 2024

Thanks for your help, I wish I knew that last time. It built successfully, so it seems I was lucky to have only one problem with my code. Hope it works well.

@ILIYANGERMANOV ILIYANGERMANOV merged commit fc9d3bf into Ivy-Apps:main Jan 21, 2024
6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Top of the main screen (date) covers x3 place after changing date to view previous month
2 participants