You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've managed to generate a R8-optimized (minify, obfuscate, and shrink resources) APK with your changes. 👌
It's way faster than the debug build type but sometimes it may crash. So please, test and enjoy your lightning-fast Ivy-Wallet-Demo.apk. ⚡
Note: It's important to download and test this APK artifact from the "APK" workflow or the link above because it may introduce runtime crashes in production.
📖
Detekt check finished 🕵️♂️
Our code quality check completed. ✅
If it fails, open the "Detekt" workflow run on your PR, scroll down and download the attached detekt-report.html. Please, inspect it and try to fix the errors. 🔎
Pstt, don't worry - sometimes Detekt gives false-positives. Your reviewer will guide you towards the best next steps. 👍
Congratulations! 🎉 You're almost there...
Your PR is a fact and it'll be reviewed as soon as possible. The last step is to receive an approving review and merge it. ✅
The final thing left to do is:
Upload a screen recording to prove that your code works. (without it we can't merge your PR)
Code quality tips:
The keyword is simplicity.
Can I do it in a more simple and straightforward way?
Can I do it with less code? If so, delete what's unnecessary.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) Checklist
Please check if your pull request fulfills the following requirements:
main
branch.What's changed?
Describe with a few bullets what's new:
💡 Tip: Please, attach screenshots and screen recordings. It helps a lot!
Risk Factors
What may go wrong if we merge your PR?
In what cases your code won't work?
Does this PR closes any GitHub Issues?
Check Ivy Wallet Issues.
Replace
{ISSUE_NUMBER}
with the id/number of the issue that you've fixed.