Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Modularization #1: by screen #2611

Merged
merged 14 commits into from
Sep 12, 2023
Merged

Modularization #1: by screen #2611

merged 14 commits into from
Sep 12, 2023

Conversation

ILIYANGERMANOV
Copy link
Collaborator

Pull Request (PR) Checklist

Please check if your pull request fulfills the following requirements:

  • The PR is submitted to the main branch.
  • I've read the Contribution Guidelines.
  • The code builds and is tested on a real Android device.
  • I confirm that I've run the code locally and everything works as expected.

What's changed?

Describe with a few bullets what's new:

  • a
  • b
  • c
  • d

💡 Tip: Please, attach screenshots and screen recordings. It helps a lot!

Risk Factors

What may go wrong if we merge your PR?

  • a
  • b
  • c

In what cases your code won't work?

  • a
  • b
  • c

Does this PR closes any GitHub Issues?

Check Ivy Wallet Issues.

  • Closes #{ISSUE_NUMBER}

Replace {ISSUE_NUMBER} with the id/number of the issue that you've fixed.

@ivywallet
Copy link
Collaborator

ivywallet commented Sep 12, 2023

Messages
📖

APK ready ✅

We've managed to generate a R8-optimized (minify, obfuscate, and shrink resources) APK with your changes. 👌

It's way faster than the debug build type but sometimes it may crash. So please, test and enjoy your lightning-fast Ivy-Wallet-Demo.apk. ⚡

Note: It's important to download and test this APK artifact from the "APK" workflow or the link above because it may introduce runtime crashes in production.

📖

Detekt check finished 🕵️‍♂️

Our code quality check completed. ✅

If it fails, open the "Detekt" workflow run on your PR, scroll down and download the attached detekt-report.html. Please, inspect it and try to fix the errors. 🔎

Pstt, don't worry - sometimes Detekt gives false-positives. Your reviewer will guide you towards the best next steps. 👍

Congratulations! 🎉 You're almost there...

Your PR is a fact and it'll be reviewed as soon as possible. The last step is to receive an approving review and merge it. ✅

The final thing left to do is:

  • Upload a screen recording to prove that your code works. (without it we can't merge your PR)

Code quality tips:

  • The keyword is simplicity.
  • Can I do it in a more simple and straightforward way?
  • Can I do it with less code? If so, delete what's unnecessary.
  • Did I over-engineer it?

Thank you for your contribution! 👏

Generated by 🚫 dangerJS against 7ef0a12

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants