-
Notifications
You must be signed in to change notification settings - Fork 712
Conversation
Congratulations! 🎉 You're almost there...Your PR is a fact and it'll be reviewed as soon as possible. The last step is to receive an approving review and merge it. ✅ The final thing left to do is:
Code quality tips:
Thank you for your contribution! 👏 |
0272c84
to
197d27b
Compare
* Improve the "detektFormat" task * Fix the pre-push hook * Test the pre-push hook * Fix file formatting * Fix messed up files * Setup DangerJS * Attempt Danger to comment with the Detekt report * Try to comment APK file on the PR using Danger * Update apk.yml * Remove 5k node modules form .gitignore * WIP: Setup DangerJS + upgrade wrapper * Danger PR * Danger PR (fix Markdown #1) * Add danger comment for the "APK" workflow * Add Danger Detekt * Fix the Danger comment in Detekt * Update Danger * Fix Danger "Detekt" message * WIP Danger * DangerJS devexp v0.0.1? * Rerun CI * Improve Danger * Improve Danger comments * Improve Danger comments 2 * Improve Detekt messages * Danger messages * Update Detekt baseline * Add "What's changed?" tip * PR template improvement
Pull Request (PR) Checklist
Please check if your pull request fulfills the following requirements:
main
branch.What's changed?
Describe with a few bullets what's new:
💡 Tip: Please, attach screenshots and screen recordings. It helps a lot!
Risk Factors
What may go wrong if we merge your PR?
In what cases your code won't work?
Does this PR closes any GitHub Issues?
Check Ivy Wallet Issues.
Replace
{ISSUE_NUMBER}
with the id/number of the issue that you've fixed.