Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Devexp #2582

Merged
merged 30 commits into from
Sep 9, 2023
Merged

Devexp #2582

merged 30 commits into from
Sep 9, 2023

Conversation

ILIYANGERMANOV
Copy link
Collaborator

Pull Request (PR) Checklist

Please check if your pull request fulfills the following requirements:

  • The PR is submitted to the main branch.
  • I've read the Contribution Guidelines.
  • The code builds and is tested on a real Android device.
  • I confirm that I've run the code locally and everything works as expected.

What's changed?

Describe with a few bullets what's new:

  • a
  • b
  • c
  • d

💡 Tip: Please, attach screenshots and screen recordings. It helps a lot!

Risk Factors

What may go wrong if we merge your PR?

  • a
  • b
  • c

In what cases your code won't work?

  • a
  • b
  • c

Does this PR closes any GitHub Issues?

Check Ivy Wallet Issues.

  • Closes #{ISSUE_NUMBER}

Replace {ISSUE_NUMBER} with the id/number of the issue that you've fixed.

@ivywallet
Copy link
Collaborator

ivywallet commented Sep 4, 2023

Messages
📖

Detekt check finished 🕵️‍♂️

Our code quality check completed. ✅

If it fails, open the "Detekt" workflow run on your PR, scroll down and download the attached detekt-report.html. Please, inspect it and try to fix the errors. 🔎

Pstt, don't worry - sometimes Detekt gives false-positives. Your reviewer will guide you towards the best next steps. 👍

📖

APK ready ✅

We've managed to generate a R8-optimized (minify, obfuscate, and shrink resources) APK with your changes. 👌

It's way faster than the debug build type but sometimes it may crash. So please, test and enjoy your lightning-fast Ivy-Wallet-Demo.apk. ⚡

Note: It's important to download and test this APK artifact from the "APK" workflow or the link above because it may introduce runtime crashes in production.

Congratulations! 🎉 You're almost there...

Your PR is a fact and it'll be reviewed as soon as possible. The last step is to receive an approving review and merge it. ✅

The final thing left to do is:

  • Upload a screen recording to prove that your code works. (without it we can't merge your PR)

Code quality tips:

  • The keyword is simplicity.
  • Can I do it in a more simple and straightforward way?
  • Can I do it with less code? If so, delete what's unnecessary.
  • Did I over-engineer it?

Thank you for your contribution! 👏

Generated by 🚫 dangerJS against 7f5bd54

@ILIYANGERMANOV ILIYANGERMANOV merged commit 9f73c9d into main Sep 9, 2023
5 checks passed
@ILIYANGERMANOV ILIYANGERMANOV deleted the devexp branch September 9, 2023 14:37
mohammednawas8 pushed a commit to mohammednawas8/ivy-wallet that referenced this pull request Sep 9, 2023
* Improve the "detektFormat" task

* Fix the pre-push hook

* Test the pre-push hook

* Fix file formatting

* Fix messed up files

* Setup DangerJS

* Attempt Danger to comment with the Detekt report

* Try to comment APK file on the PR using Danger

* Update apk.yml

* Remove 5k node modules form .gitignore

* WIP: Setup DangerJS + upgrade wrapper

* Danger PR

* Danger PR (fix Markdown #1)

* Add danger comment for the "APK" workflow

* Add Danger Detekt

* Fix the Danger comment in Detekt

* Update Danger

* Fix Danger "Detekt" message

* WIP Danger

* DangerJS devexp v0.0.1?

* Rerun CI

* Improve Danger

* Improve Danger comments

* Improve Danger comments 2

* Improve Detekt messages

* Danger messages

* Update Detekt baseline

* Add "What's changed?" tip

* PR template improvement
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants