Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

WIP Version catalog + Devex fixes #2531

Merged
merged 4 commits into from
Sep 2, 2023
Merged

WIP Version catalog + Devex fixes #2531

merged 4 commits into from
Sep 2, 2023

Conversation

ILIYANGERMANOV
Copy link
Collaborator

Pull Request (PR) Checklist

Please check if your pull request fulfills the following requirements:

  • The PR is submitted to the main branch.
  • I've read the Contribution Guidelines.
  • The code builds and is tested on a real Android device.
  • I confirm that I've run the code locally and everything works as expected.
  • Request a review from @ILIYANGERMANOV.

Put an x in the boxes that apply.

  • Demo: Checking checkbox using [x]

Upload a screen recording + screenshots to prove that your changes work.

Pull Request Type

Please check the type of the changes that your PR introduce:

  • Bugfix
  • Feature
  • Code style update (formatting, new lines, etc.)
  • Refactoring (no functional changes, renaming)
  • Small improvement (fix typo, UI fine-tune or something small)
  • Gradle Build related changes
  • Dependencies update (updating libraries)
  • Documentation (clarifying comments, KDoc)
  • Tests (Unit, Integration, UI tests)
  • Other (please describe):

Put an x in all the boxes that apply.

What's changed?

Describe with a few bullets what's new:

  • a
  • b
  • c
  • d

💡 Tip: Attach screenshots and screen recordings. It helps a lot!

Does this PR closes any GitHub Issues?

Check Ivy Wallet Issues.

  • Closes #{ISSUE_NUMBER}

Replace {ISSUE_NUMBER} with the id/number of the issue that you've fixed.

Final Steps

Test your build again with the app-demo.apk generated by the APK workflow. This is an important step because it applies code obfuscation and R8 that often produces runtime exceptions which make the app crash.

We don't have QA, you are the QA! That's why we require so much testing.

If everything still works fines, comment and tag @ILIYANGERMANOV. He'll try to merge your PR whenever possible.

Thank you for your contribution! 🎉

@ILIYANGERMANOV ILIYANGERMANOV merged commit 8b0c1d6 into main Sep 2, 2023
@ILIYANGERMANOV ILIYANGERMANOV deleted the version-catalog branch September 2, 2023 13:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant