Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Add themed icon support #1849

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Add themed icon support #1849

merged 1 commit into from
Feb 3, 2023

Conversation

Aritzherrero4
Copy link
Contributor

@Aritzherrero4 Aritzherrero4 commented Feb 3, 2023

Pull Request (PR) Checklist

  • The PR is submitted to the develop branch.
  • I understand the Ivy Developer Guidelines.
  • I've read the Contribution Guidelines.
  • The code builds and is tested on an actual Android device.
  • I confirm that I've run the code locally and everything works as expected.
  • I confirm that I've run Ivy Wallet's UI tests (androidTest) and all tests are passing
    successfully.

Pull Request Type

  • Bugfix
  • Feature
  • Code style update (formatting, new lines, etc.)
  • Refactoring (no functional changes, renaming)
  • Small improvement (fix typo, UI fine-tune, change color or something small)
  • Gradle Build related changes
  • Dependencies update (updating libraries)
  • Documentation (clarifying comments, KDoc)
  • Tests (Unit, Integration, UI tests)
  • Other (please describe):

Does this PR closes any GitHub Issues?

What's changed?

image

The change is an addition to an API the app already uses (adaptive icons). The monochrome icon is only used if the phone has SDK33 and themed icon enabled on the launcher.

Confirmed with the emulator (SDK28) that the icon doesn't break, neither on previous android versions nor with the themed icons disabled on A13.

@ILIYANGERMANOV ILIYANGERMANOV merged commit b620c21 into Ivy-Apps:prod Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants