[BUG] Manual time entry during transaction reverts 6 hours earlier

[asadmash]

Please confirm the following

• I checked the current issues for duplicate problems

Describe the bug

When manually entering a time while adding a transaction, the time reverts to 6 hours earlier than the intended entry. Automatic time picking works correctly, and the issue is specific to manual time entry for transactions.

To Reproduce

1. Set the device to UTC (+06:00) BST time zone.
2. Add a transaction and enter a specific time manually.
3. Observe that the time shifts 6 hours earlier than the entered time.

Expected behavior

The manually entered time for a transaction should match the intended time without any time shift.

Screenshots

No response

App version

Latest demo APK from TG

Smartphone

Symphony Z40 Android 10

Additional context

Time Zone: UTC (+06:00) BST

[ivywallet]

Thank you @asadmash for raising Issue #3451! 🚀
What's next? Read our Contribution Guidelines 📚.

Tagging @ILIYANGERMANOV for review & approval 👀

[ILIYANGERMANOV]

I'm on it

[ivywallet]

Thank you for your interest @ILIYANGERMANOV! 🎉
Issue #3451 is assigned to you. You can work on it! ✅

If you don't want to work on it now, please un-assign yourself so other contributors can take it.

Also, make sure to read our Contribution Guidelines.

[ILIYANGERMANOV]

Should be fixed in #3453

[jamilxt]

It's not happening in Emulator, rather in real device. I've debugged it, found out, the method updateDateTime() is called, the date is converting it to UTC which is causing the date to set previous date than selcted date.

May I know, why are you converting the datetime to UTC?

[ILIYANGERMANOV]

It's not happening in Emulator, rather in real device. I've debugged it, found out, the method updateDateTime() is called, the date is converting it to UTC which is causing the date to set previous date than selcted date.

May I know, why are you converting the datetime to UTC?

All records in the DB should be in UTC so they are timezone agnostic. Can you test the latest version? It should fix this issue

[jamilxt]

The screenshot is taken after running the latest code from the "main" branch.
Unable to produce the bug on the emulator. But, it's happening in my physical device.

[jamilxt]

My suggestion will be - to convert dateTime in UTC in Repository layer while saving the data, rather than in viewModel. After retriving from DB, we can convert it to user's timezone. We can utilize Room's TypeConverter feature for that?

[jamilxt]

Handling this centrally will improve maintainability, as it eliminates the need to manually implement it everywhere, reducing errors.

[ILIYANGERMANOV]

@jamilxt yes it should be centralized but we have a lot of legacy code that works with LocalDateTime. A good solution would be:

• Always work with Instant (UTC)
• Firmat this Instant to String (timezone) included before displaying it in the UI

Having LocalDateTime in the UI is terrible for a few reasons:

• It's inefficient: formatting being done in the Compsable and repeated on each recomposition
• It also makes composables unstable
• The timezone bugs that we have

However, I don't have the time to migrate all legacy code so tried to hotfix it with back and forth time conversions. My point is that if we make everything Instant there will be no need for conversions