Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

[FEATURE] Re-design "Categories" view #3364

Closed
3 tasks done
vraj152 opened this issue Jul 23, 2024 · 6 comments · Fixed by #3431
Closed
3 tasks done

[FEATURE] Re-design "Categories" view #3364

vraj152 opened this issue Jul 23, 2024 · 6 comments · Fixed by #3431
Assignees
Labels
approved Approved by the Ivy Wallet team. Ready for dev user request Feature/improvement requested by an user

Comments

@vraj152
Copy link

vraj152 commented Jul 23, 2024

Please confirm the following:

  • I've checked the current issues for duplicate issues.
  • I've requested a single (only one) feature/change in this issue. It complies with the One Request Per GitHub Issue (ORPGI) rule.
  • My issue is well-defined and describes how it should be implemented from UI/UX perspective.

What do you want to be added or improved?

Note: Similar concern for different view has been raised here - #3297

Most if not all, categories will have "expense" (not income) - Consider this screenshot. The space here is mostly wasted.

SS

Why do you need it?

No response

How do you imagine it?

No response

@vraj152 vraj152 added the user request Feature/improvement requested by an user label Jul 23, 2024
@ivywallet
Copy link
Collaborator

Thank you @vraj152 for raising Issue #3364! 🚀
What's next? Read our Contribution Guidelines 📚.

Tagging @ILIYANGERMANOV for review & approval 👀

@ILIYANGERMANOV ILIYANGERMANOV added the approved Approved by the Ivy Wallet team. Ready for dev label Jul 23, 2024
@rodrigomatosc
Copy link
Contributor

I'm on it

@ivywallet
Copy link
Collaborator

Thank you for your interest @rodrigomatosc! 🎉
Issue #3364 is assigned to you. You can work on it! ✅

If you don't want to work on it now, please un-assign yourself so other contributors can take it.

Also, make sure to read our Contribution Guidelines.

@rodrigomatosc
Copy link
Contributor

@ILIYANGERMANOV, what are your thoughts on this redesign?

Screenshot 2024-08-23 at 14 07 56 Screenshot 2024-08-23 at 14 07 42

@ILIYANGERMANOV
Copy link
Collaborator

ILIYANGERMANOV commented Aug 23, 2024

@ILIYANGERMANOV, what are your thoughts on this redesign?

Screenshot 2024-08-23 at 14 07 56 Screenshot 2024-08-23 at 14 07 42

Misses information about which account is excluded. Also make sure to gate it via IvyFeatures. The compact design should be disabled by default.

My feedback:

  • Reduce spacing between accounts
  • Make the Balance text a bit bigger to match the icon size
  • Support base currency equivalent (e.g. accounts that are not in base currency)

@stefanilijev97 for design feedback

@ILIYANGERMANOV
Copy link
Collaborator

Looks compact 💯 These are categories (forget about excluded accounts) I thought you were redesigning the Accounts tab (which btw can look similarly)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Approved by the Ivy Wallet team. Ready for dev user request Feature/improvement requested by an user
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants