Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable tabbing through script list #176

Merged
merged 2 commits into from
Sep 20, 2020
Merged

enable tabbing through script list #176

merged 2 commits into from
Sep 20, 2020

Conversation

nhnicwaller
Copy link
Contributor

When the script picker is open, this allows pressing Tab to scroll down the list, or Shift-Tab to scroll back up.

Also fixes bug #173 where the insertion point falls through into the document if you press Tab twice.

sonarcloud doesn't like this variable name, which is too bad because I copied it from Apple's docs.
@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@IvanMathy
Copy link
Owner

Looks good! I might change the behavior later since I believe tab should move focus from the textfield to the list of scripts, but I need to play more with it to see if it feels right.

Thanks for the contribution!

@IvanMathy IvanMathy merged commit 4f45d92 into IvanMathy:main Sep 20, 2020
@nhnicwaller nhnicwaller deleted the tabs branch September 21, 2020 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants