Feat: new arch support #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanIhnatsiuk
force-pushed
the
feat/new-arch-support
branch
from
008f719 to
e47ebb7
Compare
| @@ -1,5 +1,5 @@ | |||
| package com.maskedtextinput.events | |||
|
|
|||
| object EventNames { | |||
| const val CHANGE_TEXT_EVENT = "changeText" | |||
| const val CHANGE_TEXT_EVENT = "onAdvancedMaskTextChange" | |||
There was a problem hiding this comment.
Personally me - I am keeping this as a companion object for Event class. I think such approach better follows SOLID principles where you should have only one reason to change a file
If you keep all events in one class, then you have more reasons: you may add new event, you may remove old event, etc.
| @@ -41,34 +42,32 @@ class MaskedTextInputDecoratorViewManager( | |||
| } | |||
|
|
|||
| @ReactProp(name = "defaultValue") | |||
| fun setDefaultValue( | |||
| view: MaskedTextInputDecoratorView, | |||
| override fun setDefaultValue( | |||
There was a problem hiding this comment.
I think this property comes from RN? Why do you need to manage these properties?..
| textView.delegate = maskInputListener | ||
| updateTextWithoutNotification(text: defaultValue as String) | ||
| } | ||
| private func finTextField() { |
There was a problem hiding this comment.
Better to add spell check to prevent such issues in future 🙂
I found a way how to run cspell for entire project, you know where you can take a reference 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a developer, I want to add support for the new arch to have the latest features and make this library compatible with applications that enable the new arch.