Added tests for smart contract #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damienen
suggested changes
Nov 30, 2022
tests/rust_tests.rs
Outdated
| .execute_query(&setup.contract_wrapper, |sc| { | ||
| sc.require_value_is_positive(&managed_biguint!(0u64)); | ||
| }) | ||
| .assert_error(4, "Value must be positive"); |
There was a problem hiding this comment.
Error returned by that function should be changed to "Value must be higher than or equal to zero" if it accepts 0, too. Value must be positive can be misleading
| } | ||
|
|
||
| #[test] //Tests the whitelist functionality | ||
| fn white_list_test() { |
There was a problem hiding this comment.
Name is too similar to the other whitelist_test
tests/rust_tests.rs
Outdated
| @@ -127,6 +137,43 @@ fn pause_test() { | |||
| .assert_ok(); | |||
| } | |||
|
|
|||
| #[test] // Tests if the contract has whitelist enabled and is empty | |||
There was a problem hiding this comment.
Should change comment to "Tests if the contract has whitelist enabled and is empty by default after deployment"
tests/rust_tests.rs
Outdated
| @@ -127,6 +137,43 @@ fn pause_test() { | |||
| .assert_ok(); | |||
| } | |||
|
|
|||
| #[test] // Tests if the contract has whitelist enabled and is empty | |||
| // Tests if the royalties and supply are set accordingly | |||
| fn whitelist_test() { | |||
There was a problem hiding this comment.
Why is the test named whitelist_test if it also tests royalties?
tests/rust_tests.rs
Outdated
| } | ||
|
|
||
| #[test] // Tests burn functionality | ||
| fn burn_token_tests() { |
There was a problem hiding this comment.
This method is named "tests" while the others are named "test". Small detail, but generally we should try following a pattern
damienen
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.