Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOB-9446] enhance push notification state tracking #855

Merged

Conversation

evantk91
Copy link
Contributor

@evantk91 evantk91 commented Jan 2, 2025

🔹 Jira Ticket(s) if any

✏️ Description

This pull request enhances push notification state tracking. This cherry picks the changes from PR #843 to merge into master branch.

@evantk91 evantk91 changed the title [MOB-9446] enhance push notification state tracking in sd ks [MOB-9446] enhance push notification state tracking Jan 3, 2025
Copy link
Contributor

@sumeruchat sumeruchat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add unit tests (just one is fine) if possible

@@ -49,7 +50,7 @@ public class IterableApi {
private String inboxSessionId;
private IterableAuthManager authManager;
private HashMap<String, String> deviceAttributes = new HashMap<>();
private IterableKeychain keychain;
public IterableKeychain keychain;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we revert this

}
fetchRemoteConfiguration();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldnt fetchRemoteConfiguration be inside the if

@joaodordio joaodordio assigned joaodordio and unassigned joaodordio Jan 9, 2025
@evantk91 evantk91 merged commit 33f69c3 into master Jan 9, 2025
3 of 4 checks passed
@evantk91 evantk91 deleted the evan/MOB-9446-Enhance-Push-Notification-State-Tracking-in-SDKs branch January 9, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants