Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOB-9101] - EM OOTB Button Text Crop Fix #846

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

Ayyanchira
Copy link
Member

@Ayyanchira Ayyanchira commented Dec 11, 2024

🔹 Jira Ticket(s) if any

✏️ Description

Adjusted button padding.
New Android Version seem to have more padding for buttons. Also there was hardcoded padding added to top and bottom. Hence explicitly adding 0

Adjusted button padding.
New Android Version seem to have more padding for buttons. Also there was hardcoded padding added to top and bottom. Hence explicitly adding 0
@Ayyanchira Ayyanchira requested a review from evantk91 December 11, 2024 21:56
Copy link
Contributor

@evantk91 evantk91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Akshay demoed on sync. The integration test is failing but I think its a flaky test.

@Ayyanchira Ayyanchira merged commit 4b711be into master Dec 12, 2024
4 checks passed
@Ayyanchira Ayyanchira deleted the MOB-9101-EM-Button-Cut-Fix branch December 12, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants