-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MOB-10094] merging bug fix #827
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/itbl-track-anon-user #827 +/- ##
================================================================
- Coverage 60.17% 60.10% -0.08%
================================================================
Files 86 86
Lines 5961 5960 -1
Branches 756 756
================================================================
- Hits 3587 3582 -5
- Misses 2001 2003 +2
- Partials 373 375 +2 ☔ View full report in Codecov by Sentry. |
[MOB-10098] updates user update parsing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. JWT flow needs to be tested properly though
} else { | ||
getAuthManager().requestNewAuthToken(false, data -> attemptMergeAndEventReplay(userIdOrEmail, isEmail, merge, replay, failureHandler)); | ||
getAuthManager().requestNewAuthToken(false, data -> attemptMergeAndEventReplay(userIdOrEmail, isEmail, merge, replay, isAnon, failureHandler)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a JWT perspective, we will have to check how it plays with timings of JWT RetryPolicy. It might have to go through scheduling a new request instead of requesting right away.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. I will make a ticket for tracking.
🔹 Jira Ticket(s) if any
✏️ Description