Evan/feature/placement support #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te-local-storage-and-handlers
…age-and-handlers [MOB-6733] update local storage and handlers
…acement-support [MOB-7179] updates reset function for placement support
…te-get-messages-for-placements
…alization-tests [MOB-7349] placements serialization tests
…es-for-placements [MOB-6731] updates get messages for placement support
Ayyanchira
reviewed
Dec 6, 2023
iterableapi/src/main/java/com/iterable/iterableapi/IterableApi.java
Outdated
Show resolved
Hide resolved
iterableapi/src/main/java/com/iterable/iterableapi/IterableApi.java
Outdated
Show resolved
Hide resolved
iterableapi/src/main/java/com/iterable/iterableapi/IterableApi.java
Outdated
Show resolved
Hide resolved
iterableapi/src/main/java/com/iterable/iterableapi/IterableApiClient.java
Outdated
Show resolved
Hide resolved
iterableapi/src/main/java/com/iterable/iterableapi/IterableApiClient.java
Outdated
Show resolved
Hide resolved
iterableapi/src/main/java/com/iterable/iterableapi/IterableApiClient.java
Outdated
Show resolved
Hide resolved
Comment on lines
141
to
156
| val localMessageList = getMessages().toMutableList() | ||
| val localMessageMap = mutableMapOf<String, IterableEmbeddedMessage>() | ||
| localMessageList.forEach { | ||
| getMessages(placementId)?.toMutableList()?.forEach { | ||
| localMessageMap[it.metadata.messageId] = it | ||
| } | ||
|
|
||
| // Check for new messages and add them to the local list | ||
| remoteMessageList.forEach { | ||
| if (!localMessageMap.containsKey(it.metadata.messageId)) { | ||
| localMessagesChanged = true | ||
| localMessageList.add(it) | ||
| IterableApi.getInstance().trackEmbeddedMessageReceived(it) |
There was a problem hiding this comment.
Needs revisit. Check if the trackEmbeddedMessage is called for previously received message.
Comment on lines
161
to
172
| val messagesToRemove = mutableListOf<IterableEmbeddedMessage>() | ||
| localMessageList.forEach { | ||
| if (!remoteMessageMap.containsKey(it.metadata.messageId)) { | ||
| messagesToRemove.add(it) | ||
|
|
||
| //TODO: Make a call to the updateHandler to notify that the message has been removed | ||
| //TODO: Make a call to backend if needed | ||
| localPlacementMessagesMap[placementId]?.forEach { | ||
| if (!remoteMessageMap.containsKey(it.metadata.messageId)) { | ||
| localMessagesChanged = true | ||
| } | ||
| } | ||
| localMessageList.removeAll(messagesToRemove) | ||
|
|
||
| this.localMessages = localMessageList | ||
| localPlacementMessagesMap[placementId] = remoteMessageList |
Ayyanchira
reviewed
Dec 11, 2023
iterableapi/src/main/java/com/iterable/iterableapi/IterableEmbeddedManager.kt
Outdated
Show resolved
Hide resolved
iterableapi/src/main/java/com/iterable/iterableapi/IterableEmbeddedManager.kt
Outdated
Show resolved
Hide resolved
iterableapi/src/test/java/com/iterable/iterableapi/IterableEmbeddedManagerTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s) if any
✏️ Description